Open
Conversation
Owner
|
Nice catch, thank you for reporting and bringing the fix! |
Owner
|
Sorry for the late reply. I'll debug the two failing tests (test_pytorch_data_loading.py::test_dataset_midi with pertok) this week-end |
Author
|
That's no problem. From your previous comment I understood that any failing tests were likely due to causes other than my PR, but if that's mistaken and this PR is causing tests to newly fail I can debug the failing tests as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue described in #263 .
The change is to add 1 to
max_tickwhenonly_notes_onsetsis True. Then, we calculate the bars in a way that is inclusive of the last onset, rather than exclusive of it. This causes the test case in the linked issue to pass.If you'd like to add the test case to the
testsfolder I can do that as well.📚 Documentation preview 📚: https://miditok--264.org.readthedocs.build/en/264/