Repository navigation
Conversation
The sheet's field stopped at eight lines with its own scroll bar, inside a scroll view, with empty space under it. Now nothing scrolls but the field. It gets as many lines as fit between the author row and the toolbar, less whatever sits under it: photos, the poll editor, the quoted commit or the schedule box. ComposerSheet works those heights out, since neither platform tells PHP how tall the sheet is and mobile-ui's multiline field sizes itself in lines rather than to the space it's given. The mention list is no longer in the layout. It floats over the field and the quoted commit, on Liquid Glass on iOS and a raised surface on Android, from just under the caret's line down to the toolbar, and scrolls inside. The caret's line is estimated from the text before it, wrapped at the field's width, because the field doesn't report where the caret is drawn. Each part of the sheet has a keyed slot that is always drawn, so the field keeps its id and its place among its siblings and the keyboard stays up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tions by its caret The sheet's field had its lines worked out from an estimate of the sheet's height and of everything under it, and the mention list's top from the text before the caret, wrapped at a guessed width. mobile-ui#227 lets a multiline field fill the height it's given (h-full) and report where its caret is drawn (@caretChange), so the field is now h-full in a flex-1 slot and the list starts just under the caret's line as the field reports it. ComposerSheet keeps only the list's placement. Its line and height estimates, and the 24pt line height set on the field for them, are gone. Tests of the fill and the caret skip on a mobile-ui without them (Tests\Support\TextFieldFill), where the field is as tall as its lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the mention list doesn't fit between the caret's line and the field's bottom, the field now gets shorter instead, ending on the caret's line, and the list goes under it down to the toolbar. Before, the list moved up to make room for three people and could cover the line being typed on. The list is as tall as its rows (up to six) when it floats, so it only scrolls when it has to. Once the list goes, the field fills again. The body area has animate-layout (mobile-air#736), so the field's height and the list coming and going are animated. The field slot keeps its key and place, so the keyboard stays up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
added a commit
that referenced
this pull request
Nov 21, 2026
…scroll The composer sheet in #198 sizes its mention list and scrolls it. With more than six rows the partial's own six-row scroll view sat inside that one, so a short phone showed two scroll bars. 'scrolls' => false draws every row as tall as it is with no scroll view inside. It defaults to true, so the reply bar and the conversation bar keep their six-row list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sheet sizes its mention list and scrolls it. #196 gives the shared mention list a six-row scroll view of its own, so once both are merged a list of more than six would show two scroll bars on a short phone. The sheet now passes 'scrolls' => false, which #196 adds. Before #196 merges the partial ignores it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Draft
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill the composer sheet with the field, and put mentions by its caret.
Needs NativePHP/mobile-ui#227 (which carries mobile-ui#218 under it). Without it the field is only as tall as its lines and the mention list sits under the first line. The tests for both skip on a mobile-ui without it (
Tests\Support\TextFieldFill).Also uses NativePHP/mobile-air#736 (with NativePHP/mobile-ui#225) for
animate-layout. Without it the sheet works the same, the field and the list just jump instead of moving. The test that reads it skips without it (Tests\Support\LayoutAnimation, the same file as in #196).For a build before those are merged, the vendor patches are in
storage/app/patches(not committed, it's under the ignoredstorage/app):mobile-ui-text-fill-caret.patch(#227 at aaf451e),mobile-air-736-layout-animation.patchandmobile-ui-225-layout-animation.patch. A vendor that already has #227's earlier head only needsmobile-ui-227-caret-shrink.patchon top.The New commit, Quote and Reply sheet had its field inside a scroll view. The field stopped at eight lines with its own scroll bar and left empty space above the toolbar, and the mention list sat in the flow under the field, so three things could scroll at once.
Based on #194 (fix/reply-bar-spacing-and-fade), which sits on #192 and is the newest branch with the sheet as build 40 draws it. The sheet, reply-field, mention-suggestions and composer-box are the same there as in build 40.
What changed in the sheet:
h-fullin aflex-1slot, so it reaches down to whatever is under it, or the toolbar. It never shows fewer than two lines.@caretChange, kept in$sheetCaret). The list is as tall as its rows, up to six, and scrolls inside past that. Glass on iOS like the reply bar's list, and a surface with a hairline and shadow on Android.animate-layout, so the field shortening and growing back, and the list coming and going, are animated. Photos, the poll and the preview coming and going are animated too.What a reviewer should know:
App\Devnull\ComposerSheet::mentionLayout()does the placing. The room for the list is measured to the field's bottom, because nothing reports how tall the quoted commit or poll under it is. So with something under the field the field can get shorter a little sooner than it has to. While it's shorter, what's under it comes up with it and the list covers it, as the floating list did before.scrollRangeToVisiblein the editor's probe). On Android, Compose's text field only scrolls to the caret when the caret moves, so mobile-ui#227 now asks the field to bring the caret into view when it gets shorter (aaf451e there). With an older #227 the caret's line can sit under the field's new bottom until the next keystroke.animate-layoutslides children to their new places but doesn't animate size, so there the list slides and fades in and the field's height changes at once.'scrolls' => false(75cb547), which Open every level of replies in place on the commit page, and move the page within its tree #196 adds (f9832b5 there). Before Open every level of replies in place on the commit page, and move the page within its tree #196 merges the partial ignores it. With both merged there's one scroll view in the sheet's list, so a short phone doesn't show two scroll bars.Not built on a device, so no screenshots yet. Tests:
php artisan testpasses (1969) with all three patches in vendor. Without mobile-air#736 one fewer passes and 1 skips, and without #227 the fill and caret tests skip as before. A newCommitMentionsTestcase puts nine suggestions in the sheet and checks its list has exactly one scroll view. Merged with #196's f9832b5 into the phone build (local/iphone-items-1-7, in a scratch copy) the sheet and mention tests pass and the whole suite passes (2202). Take the sheet's'scrolls' => falseout there and that case fails with two scroll views.Screenshots
Not taken yet: this needs a build on a phone.
🤖 Generated with Claude Code