Repository navigation
Conversation
…ith the actions Replies no longer show under a commit in a feed. The replies button moves to its own line under the action row and opens the thread in place, ten replies at a time, with Show more for the next ten. A reply has the same button under its own actions, which opens its replies inline one step in. Deeper than that, the button opens the reply's page. devnull's API sends 50 replies a page whatever `limit` asks for, so the app keeps what it was sent and shows ten at a time, asking for the next page only once they all show. The end dot of a commit's rail is now drawn inside its action row, so it sits level with the actions whatever is above or below them. It used to be placed a fixed distance from the row's bottom, which assumed the action row's -my-[6] pulled it in. iOS does that, Android keeps the space and only moves the drawing, and a row with a thread under it had no bottom padding, so the dot sat above the actions in some rows and below in others. The action row now has no vertical negative margins, and the rail's lines are worked out from the fixed heights under it to meet the dot. Opening and closing a thread fades its rows in and out, and the chevron turns. Starring a commit pops the star as the web's star-pop does, and giving a pastel bumps it as the web's pastel button does. EDGE only animates from one frame to the next, so each step is a frame drawn when a short background Beat comes back. Quote now has its label beside its icon, as Reply always does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On the Log, opening or closing a commit's replies dropped or added the 7pt under its replies line, where the hairline sits. When the commit's top was off screen, the iPhone's list held the row below still instead, so the commit's photo jumped by 7pt. The row now keeps that padding, the hairline's 1pt included, with its replies open, and only the hairline goes. The first reply takes the 7pt off its own top, so the thread looks the same, and the elbow and the lines beside a reply are placed from its avatar. The commit page is left as it was: it's a scroll view, which holds its top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e Log The replies button's chevron only turned in feeds, where the replies open in place. A commit page opens its commit's replies in place too, but there the chevron kept pointing right with "Hide replies" beside it. It now turns down there as well, over the same 220ms, and carries the animation while shut so iOS animates the first turn. A reply's button on a commit page still opens its page, so its chevron stays put. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nested replies on the commit page reuse #179's ExpandsThreads and ThreadRows, so this branch carries #179 on top of #195. Conflicts are resolved as on the phone build (2c46223): #195's Show thread and self-thread filtering sit in #179's ExpandsThreads, and the replies line under a commit row leaves room only when its replies button shows. The thread fixtures from 2c46223 are in too, so #179's tests don't turn into self-threads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A reply's "N replies" on the commit page used to open that reply's own page. Now it opens its replies under it, and theirs under them, as deep as they go, the way the web's commit page does. Tapping a reply still opens its page. The rows come from #179's ThreadRows, now recursive, and the threads from ExpandsThreads, which replaces the page's separate mechanism for a deleted reply's replies. Indentation stops at the web's depth of three (maxIndentDepth in commit-thread.tsx). Replies at the third step hang on their own elbow off the line of the reply they answer, and deeper ones line up under them with no lines and a "replying to @handle" line. "Show more" is a row of its own on the page too, as on the Log, and says "to @handle" past that depth. The Log keeps opening only the commit's replies in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tapping an ancestor, a part of the series or the author's thread, or a reply at any depth used to push a new commit screen. Now the same page moves to it: the commit becomes the one the page is about, with what's above it as its ancestors and its replies showing below, built from what the page already has so nothing goes blank. The commit it was on keeps its replies opened, so going back up shows where you came from. Reply on a commit in the tree retargets the reply bar the same way. Commits outside the tree still push. Back still leaves the screen, as Simon asked. There's no history of the commits the page moved through. The scroll view's rows are its own children now, so auto-scroll-to can bring the commit into view. Both platforms jump on the first request and animate later ones. Deleting a commit the page moved to takes the page back to its parent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scroll view now has animate-layout, so the rows the page keeps slide to their new places and the ones it adds or drops fade, and auto-scroll-animated, so the first move animates too. The focused commit is keyed commit-<id>, as it is among the commits above it, so moving up the tree slides that row rather than redrawing it. Going back to a row the scroll view already went to used to mount the scroll view again, which would make every row new. It now passes a new auto-scroll-token instead. These need NativePHP/mobile-air#736 and NativePHP/mobile-ui#225. Without them the move jumps, as before, and asking for the same row twice in a row doesn't scroll. The test that reads the new props skips until vendor has them (Tests\Support\LayoutAnimation). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It sat under the commit's text. Now it ends the row with the name, handle and time, pushed right by a spacer, in the same size and ink. Only the focused commit shows a hash, so no other rows change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The commits above the one the page is on keep their "N replies" button, and it now opens their replies in place under them, like the commit's and every reply's, instead of moving the page there. The reply on the line down to the commit is left out of the list and of the count, since it already shows below. Closing an ancestor's replies leaves the replies of the commits on the line open (drawsOnItsOwn in ExpandsThreads). After a move the scroll target counts the rows opened above the commit, and opening or closing them later doesn't scroll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The commits above the one the page is on now start with their replies folded behind "N replies", whether the page opened on a reply or moved down to one. Before, moving down kept the replies of the commit the page left open under it, and any opened on a commit above stayed open. Moving up, the commit the page moves to shows its replies with the way back down opened, as before. The scroll target after a move is just the ancestor count again, since nothing is open above the commit then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With more than six people and organizations to suggest, the rows sit in a scroll view six rows tall inside the suggestions, so the list can't push the field and the bar's buttons down under the keyboard. Six or fewer are drawn as before, as tall as their rows. The slot around the list keeps its place, so the field's row doesn't move among its siblings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task
…scroll The composer sheet in #198 sizes its mention list and scrolls it. With more than six rows the partial's own six-row scroll view sat inside that one, so a short phone showed two scroll bars. 'scrolls' => false draws every row as tall as it is with no scroll view inside. It defaults to true, so the reply bar and the conversation bar keep their six-row list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
added a commit
that referenced
this pull request
Nov 21, 2026
The sheet sizes its mention list and scrolls it. #196 gives the shared mention list a six-row scroll view of its own, so once both are merged a list of more than six would show two scroll bars on a short phone. The sheet now passes 'scrolls' => false, which #196 adds. Before #196 merges the partial ignores it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the commit page, one commit each.
f03090c: a reply's "N replies" used to open that reply's own page, so going deeper meant pushing screen after screen. Now it opens the replies under it in place, and theirs under them, as deep as they go. This is what the web's commit page does.
a0032d3: tapping a commit that's already in the page's tree (an ancestor, a series or self-thread part, a reply at any depth) moves the same page to it instead of pushing another commit screen. Commits outside the tree, profiles and links still push.
Merge order: this is based on #195 (feat/self-threads) and has #179 (feat/log-threads) merged in. It reuses #179's
ExpandsThreadsandThreadRows, and #179 and #195 conflict, so the branch carries a merge commit (083085a) resolved the same way as the phone build (2c46223), with its thread test fixtures. Merge #179 and #195 first; then this diff shrinks to this PR's own commits.How the web does it
From
resources/js/components/commit-thread.tsxon production:maxIndentDepth = 3. The commit's replies are depth 1 and sit under the commit's text. Depth 2 and 3 each step in one indent.What changed
ThreadRows::under()is recursive now. It caps the indent at the web's depth (MaxIndentDepth) and takes how deep replies open in place (opensInPlace). The commit page passes no limit. The Log still passes 1, so on the Log a reply's replies still open its page. That's one argument to change if you want the Log to go deeper too.ExpandsThreadsfor replies of replies. It replaces the page's own one-level mechanism for a deleted reply's replies (tombstoneReplies,toggleTombstone), which is gone.$spines(this was a single$spine). At the third step each reply hangs on its own elbow off the line of the reply it answers, like the web. A line from avatar to avatar would otherwise run through the flattened replies lined up under it.thread-morepartial is deleted.Moving the page within the tree (a0032d3)
auto-scroll-tobring the commit into view, with all its ancestors shown above it.Animating the move (10cca47)
This needs NativePHP/mobile-air#736 and NativePHP/mobile-ui#225. Without them the app still works, but the move jumps and going back to a row the page already went to doesn't scroll.
animate-layout, so rows the page keeps slide to their new places and rows it adds or drops fade. It also hasauto-scroll-animated, so the first move animates as well.commit-<id>, the same as the commits above it, so moving up the tree slides that row into place. A reply that becomes the focused commit is still a different row (thread-reply-<id>before,commit-<id>after), so that one fades across.$scrollRequestasauto-scroll-token, which goes up on every move. Remounting would have made every row new and spoiled the animation.storage/app/patches/(mobile-air-736-layout-animation.patch,mobile-ui-225-layout-animation.patch).Replies of the commits above (16f3839)
ExpandsThreadsnow skips any reply the screen draws as its own row (drawsOnItsOwn, only overridden on the commit page).Folded replies above the commit (d204792)
You asked for the commits above to show their replies behind the button, folded, when you're on a reply. Before this, moving down to a reply kept the replies of the commit you left open under it, and any you'd opened on a commit above stayed open.
Six mentions at most (056deb8)
The reply bar's @mention suggestions could grow tall enough to push the field and the bar's buttons under the keyboard. devnull's search sends people and organizations with no limit the app sets.
partials/mention-suggestionsputs the rows in a scroll view six rows tall (Display::MentionRowsShowntimesDisplay::MentionRowHeight, 6 x 44). Each row is then exactly 44 so six fill it. Six or fewer draw as before, as tall as their rows.'scrolls' => false(f9832b5), and the rows draw as tall as they are with no scroll view inside. It defaults to true. Fill the composer sheet with the field, and float mentions over it #198's sheet sizes and scrolls its own list and passes it, so once both merge a short phone doesn't show two scroll bars there.Display::replyBarClearancedoesn't count the suggestions, and didn't before. They only show while you type a handle, and the cap now bounds how far they can lift the bar.Hash at the top right (5c5d26b)
The focused commit's short hash moved from under its text to the end of the name, handle and time row, pushed right by a spacer. Same size and ink, and still plain text as before. No other row on the page shows a hash, so nothing else moved.
Watch for
$spinesand the third-level elbows, and the replies opened under a commit above, have only been checked through the rendered tree in tests, not on a device. The x positions are 31.5 (rail), 75.5 and 107.5 (reply lines).RowCacheScreensTestnow expects one fewer rebuilt row when a page of replies arrives, because the last reply no longer carries "Show more".Tests
php -d auto_prepend_file= artisan test: 1992 passed, 1 skipped on current vendor. Before 16f3839 it was 1984 passed with the two vendor patches applied (in a scratch copy); that wasn't rerun. New:tests/Unit/Devnull/ThreadRowsTest.php(indent cap, flattened rows, third-level elbows and lines, open-in-place depth) andtests/Feature/Screens/NestedRepliesTest.php(opening five levels in place without navigating, closing a middle level, the indents and "replying to" labels, moving the page within the tree and back up, Reply retargeting the bar, commits outside the tree still pushing). Tests that expected a tap in the tree to push now expect the page to move. 10cca47 adds two toNestedRepliesTest: the focused row and the scroll view keep their node ids across a move, and the scroll view gets the new props with a fresh token when it goes back to a row it went to before (skips until vendor has #736, seeTests\Support\LayoutAnimation). 16f3839 adds three more: a commit above opening its other replies without the one on the way down, the scroll target after a move counting them, and closing a commit's replies above leaving the line's open. The hash test now checks it ends the name row. d204792 replaces two of 16f3839's tests and adds two: moving down folds the commits above (the commit left and one opened by hand), moving back up opens them again, and opening on a reply starts folded. 056deb8 adds two toCommitMentionsTest: eight suggestions scroll in a list six rows tall with the bar's slots in place, and six don't scroll. f9832b5 addsMentionSuggestionsTest, which renders the partial on its own through a test component and view (tests/Fixtures/views): eight rows scroll by default, and with'scrolls' => falseall eight draw with no scroll view.Screenshots
No device build for this one, so there are no screenshots yet. It does change what the commit page draws.
🤖 Generated with Claude Code