Feat/3824/bulletin/post and project #3825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsabor
commented
Nov 22, 2025
Comment on lines
+39
to
+47
| const questionMatch = pathname.match(/^\/questions\/(\d+)(?:\/|$)/); | ||
| if (questionMatch) { | ||
| return { post_id: Number(questionMatch[1]) }; | ||
| } | ||
|
|
||
| const projectMatch = pathname.match(/^\/tournament\/([^/]+)(?:\/|$)/); | ||
| if (projectMatch) { | ||
| return { project_slug: projectMatch[1] }; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
is there a cleaner way to do this? @ncarazon
I need the post_id or project_slug
This just reads from the URL and uses regex. Maybe we have a helper or a better way to grab the relevant post or project?
Contributor
There was a problem hiding this comment.
I’m not totally sure we already have a helper for this
Given that, I’d keep the regex logic but extract it into a small helper under utils/navigation.ts (e.g. getBulletinParamsFromPathname(pathname)), and then just call that from here.
This was referenced Nov 22, 2025
ncarazon
approved these changes
Dec 3, 2025
hlbmtc
approved these changes
Dec 3, 2025
Contributor
hlbmtc
left a comment
hlbmtc
left a comment
There was a problem hiding this comment.
LGTM, but agree with Nikita's comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3824
adds Post- and Project- level bulletins
verified functionality manually