Skip to content

Mc/3802/backend/notifications #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lsabor wants to merge 1 commit into
base: mc/3801/backend/scoring
Choose a base branch
from
Draft

Mc/3802/backend/notifications #3826

lsabor wants to merge 1 commit into from

Conversation

@lsabor
Copy link
Contributor

@lsabor lsabor commented Nov 22, 2025 •
edited
Loading

closes #3802

@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from cc59379 to a17204f Compare November 22, 2025 19:50
lsabor
lsabor commented Nov 22, 2025
View reviewed changes
notifications/templates/emails/multiple_choice_option_addition.mjml
Copy link
Contributor Author

@lsabor lsabor Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder content

lsabor
lsabor commented Nov 22, 2025
View reviewed changes
notifications/templates/emails/multiple_choice_option_deletion.mjml
Copy link
Contributor Author

@lsabor lsabor Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder content

lsabor
lsabor commented Nov 22, 2025
View reviewed changes
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from 20f99f1 to baca66b Compare November 23, 2025 18:29
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from 7c39553 to 89c28a1 Compare November 23, 2025 18:34
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from baca66b to b483002 Compare November 23, 2025 20:15
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from 89c28a1 to c1d7948 Compare November 23, 2025 20:15
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from b483002 to 753b1aa Compare November 23, 2025 20:40
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch 2 times, most recently from 06f140c to fa4a25e Compare November 23, 2025 21:23
@lsabor lsabor mentioned this pull request Nov 23, 2025
Open
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from 243cd5c to 350c67b Compare November 23, 2025 21:39
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from fa4a25e to f32b6ce Compare November 23, 2025 21:39
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from 350c67b to a585c45 Compare November 23, 2025 23:14
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from c10f5bb to e045fcb Compare November 23, 2025 23:15
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from a585c45 to c8fe000 Compare November 23, 2025 23:28
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from e045fcb to f7e1165 Compare November 23, 2025 23:29
@hlbmtc hlbmtc marked this pull request as draft November 24, 2025 11:30
@hlbmtc hlbmtc marked this pull request as ready for review November 24, 2025 11:30
@lsabor lsabor force-pushed the mc/3803/backend/endpoints branch from c8fe000 to 108d1f0 Compare November 30, 2025 23:43
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch 2 times, most recently from 683dfab to e0a42ae Compare December 1, 2025 00:04
hlbmtc
hlbmtc reviewed Dec 3, 2025
View reviewed changes
questions/tasks.py
return f"{total_seconds} second{'s' if total_seconds != 1 else ''}"


# @dramatiq.actor
Copy link
Contributor

@hlbmtc hlbmtc Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have it here?

@hlbmtc
Copy link
Contributor

hlbmtc commented Dec 3, 2025

@lsabor marking this as draft, looks like it's still WIP

@hlbmtc hlbmtc marked this pull request as draft December 3, 2025 14:28
@lsabor
mc/3802/backend/notifications
d408469 
add notification logic

add mjml and update tasks to setup for notifications

add withdrawal notifications and bulletin deactivation

spelling of arg causes failure

fix grace period end bug and skip emails
@lsabor lsabor force-pushed the mc/3802/backend/notifications branch from e0a42ae to d408469 Compare December 4, 2025 22:01
@lsabor lsabor changed the base branch from mc/3803/backend/endpoints to mc/3801/backend/scoring December 4, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hlbmtc hlbmtc hlbmtc left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsabor @hlbmtc