Allow different radial boundary conditions in multiple sections - #379
Merged
Conversation
These were only saved and reloaded in case they were used as a radial boundary condition. However, if they are used as a boundary condition, then the radial boundary points of the distribution functions will be set to the relevant values. The boundary values do not need to be saved separately unless the aim was to do an initial run with some other radial boundary condition, and then later restart setting the boundary values to the initial values from the first run - this seems like a very unlikely use-case, it is more likely that it would be useful to run one simulation (e.g. a 1D one) to steady state, then restart and fix the boundary values to the values at the beginning of the restart (which would be supported by the code as of this commit, but not the previous version).
Should be p_neutral, not pz_neutral. Correct array (p_neutral) was always passed to this function, so behaviour was correct even though argument was mis-named.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow more flexible radial boundary conditions, e.g. different bc on different boundaries, or even different parts of a single boundary.