Skip to content

fix(ci): close two failure-notification gaps #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Aug 13, 2026
+20 −2
Merged

fix(ci): close two failure-notification gaps #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/regression_reusable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ jobs:
if: success() || failure()
run: |
if [ -f deselected_tests.txt ]; then
# The testing step can die before it creates run_workdir.
mkdir -p run_workdir
mv deselected_tests.txt run_workdir/
fi
- name: Load failure-analysis prompt
Expand Down Expand Up @@ -163,11 +165,19 @@ jobs:
prompt: ${{ env.ANALYSIS_PROMPT }}
- name: Read failure analysis into env
id: read-analysis
if: (success() || failure()) && steps.testing-step.outcome != 'success' && env.HAS_OAUTH_TOKEN == 'true'
# No `env.HAS_OAUTH_TOKEN` condition here - without the token, this step still has to
# set the FAILURE_ANALYSIS placeholder that the mail body renders.
if: (success() || failure()) && steps.testing-step.outcome != 'success'
env:
EXECUTION_FILE: ${{ steps.analyze-failures.outputs.execution_file }}
ANALYZE_OUTCOME: ${{ steps.analyze-failures.outcome }}
run: |
if [ "$HAS_OAUTH_TOKEN" != "true" ]; then
echo "FAILURE_ANALYSIS=(AI failure analysis not configured - the CLAUDE_CODE_OAUTH_TOKEN secret is not set)" >> "$GITHUB_ENV"
echo "::notice::AI failure analysis skipped - the CLAUDE_CODE_OAUTH_TOKEN secret is not set."
exit 0
fi

# When the analyze step did not finish cleanly (e.g. ran out of
# turns mid-write), the analysis file may be a partial draft - mark
# it as such everywhere it is surfaced.
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/upgrade_reusable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,19 @@ jobs:
prompt: ${{ env.ANALYSIS_PROMPT }}
- name: Read failure analysis into env
id: read-analysis
if: (success() || failure()) && steps.testing-step.outcome != 'success' && env.HAS_OAUTH_TOKEN == 'true'
# No `env.HAS_OAUTH_TOKEN` condition here - without the token, this step still has to
# set the FAILURE_ANALYSIS placeholder that the mail body renders.
if: (success() || failure()) && steps.testing-step.outcome != 'success'
env:
EXECUTION_FILE: ${{ steps.analyze-failures.outputs.execution_file }}
ANALYZE_OUTCOME: ${{ steps.analyze-failures.outcome }}
run: |
if [ "$HAS_OAUTH_TOKEN" != "true" ]; then
echo "FAILURE_ANALYSIS=(AI failure analysis not configured - the CLAUDE_CODE_OAUTH_TOKEN secret is not set)" >> "$GITHUB_ENV"
echo "::notice::AI failure analysis skipped - the CLAUDE_CODE_OAUTH_TOKEN secret is not set."
exit 0
fi

# When the analyze step did not finish cleanly (e.g. ran out of
# turns mid-write), the analysis file may be a partial draft - mark
# it as such everywhere it is surfaced.
Expand Down