fix(ci): close two failure-notification gaps - #3611
Merged
Merged
Conversation
mkoura
commented
Aug 13, 2026
Collaborator
- The 'Move deselected_tests.txt artifact' step fails when the testing step dies before creating run_workdir (nix setup or workdir lock failures). Create the directory first, same as the failure-analysis steps already do.
- The failure mail does not require the CLAUDE_CODE_OAUTH_TOKEN secret, but the step that sets FAILURE_ANALYSIS did - without the token the mail rendered an empty string where the analysis belongs. Run the step regardless and set an explicit placeholder when the token is not configured.
- The 'Move deselected_tests.txt artifact' step fails when the testing step dies before creating run_workdir (nix setup or workdir lock failures). Create the directory first, same as the failure-analysis steps already do. - The failure mail does not require the CLAUDE_CODE_OAUTH_TOKEN secret, but the step that sets FAILURE_ANALYSIS did - without the token the mail rendered an empty string where the analysis belongs. Run the step regardless and set an explicit placeholder when the token is not configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.