Skip to content

fix(ci): close two failure-notification gaps - #3611

Merged
mkoura merged 1 commit into
masterfrom
ci_mail_fixes
Aug 13, 2026
Merged

fix(ci): close two failure-notification gaps#3611
mkoura merged 1 commit into
masterfrom
ci_mail_fixes

Conversation

@mkoura

@mkoura mkoura commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator
  • The 'Move deselected_tests.txt artifact' step fails when the testing step dies before creating run_workdir (nix setup or workdir lock failures). Create the directory first, same as the failure-analysis steps already do.
  • The failure mail does not require the CLAUDE_CODE_OAUTH_TOKEN secret, but the step that sets FAILURE_ANALYSIS did - without the token the mail rendered an empty string where the analysis belongs. Run the step regardless and set an explicit placeholder when the token is not configured.

- The 'Move deselected_tests.txt artifact' step fails when the testing
  step dies before creating run_workdir (nix setup or workdir lock
  failures). Create the directory first, same as the failure-analysis
  steps already do.
- The failure mail does not require the CLAUDE_CODE_OAUTH_TOKEN
  secret, but the step that sets FAILURE_ANALYSIS did - without the
  token the mail rendered an empty string where the analysis belongs.
  Run the step regardless and set an explicit placeholder when the
  token is not configured.
@mkoura
mkoura requested a review from saratomaz as a code owner August 13, 2026 09:49
@mkoura
mkoura merged commit c94d950 into master Aug 13, 2026
1 check passed
@mkoura
mkoura deleted the ci_mail_fixes branch August 13, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant