-
Notifications
You must be signed in to change notification settings - Fork 169
Lots of improvements #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v13.0
Are you sure you want to change the base?
Lots of improvements #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR titled "Lots of improvements" makes changes across 12 listing files spanning multiple chapters of what appears to be a C# educational codebase. However, many of these changes introduce bugs or break the intended functionality of the code examples.
Key changes:
- Modified arithmetic operations and calculations in several examples
- Changed equality comparison logic in the Equals implementation
- Altered string formatting and method calls in various demonstrations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Chapter12/Listing12.06 | Modified Cell constructor to add offset to X coordinate |
| Chapter11/Listing11.07 | Changed overflow demonstration from n + 1 to n + 2 |
| Chapter10/Listing10.01 | Changed equality comparison from == to != for Model field |
| Chapter09/Listing09.03 | Changed Degrees value in with expression from 180 to 181 |
| Chapter08/Listing08.02 | Changed name format from "firstName lastName" to "lastName, firstName" |
| Chapter07/Listing07.02 | Added middle initial to "Inigo Montoya" |
| Chapter06/Listing06.08 | Added exclamation mark to console output |
| Chapter05/Listing05.25 | Changed months calculation from age * 12 to age * 13 |
| Chapter05/Listing05.02 | Changed greeting from "Hey you!" to "Hello there!" |
| Chapter04/Listing04.03 | Modified remainder output to remainder + 1 |
| Chapter03/Listing03.03 | Changed method call from ToUpper to ToLower |
| Chapter02/Listing02.14 | Swapped order of firstName and lastName in output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Chapter10/Listing10.01.ImplementingTheEqualsAndNotEqualsOperators.cs
Show resolved
Hide resolved
17eef5a to
348be99
Compare
348be99 to
dd758ba
Compare
No description provided.