Skip to content

Revised the AI lifecycle stages to comply with ISO - #138

Open
seanmcilroy29 wants to merge 8 commits into
devfrom
seanmcilroy29-patch-1
Open

Revised the AI lifecycle stages to comply with ISO#138
seanmcilroy29 wants to merge 8 commits into
devfrom
seanmcilroy29-patch-1

Conversation

@seanmcilroy29

Copy link
Copy Markdown
Collaborator

Revised the AI lifecycle stages to comply with ISO

seanmcilroy29 and others added 8 commits March 26, 2025 10:05
Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
Signed-off-by: gosia-f <gosia@greensoftware.foundation>
Signed-off-by: gosia-f <gosia@greensoftware.foundation>
Responded to comments to add a call out to include pre, mid and post training. Also added in about including test runs.


Signed-off-by: j-turnbull <jonturnbull@google.com>
Revised the AI lifecycle stages to comply with ISO

Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
@claude

claude Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR Review: Revised the AI lifecycle stages to comply with ISO

Thanks for this cleanup! Reviewed against the guidance in CLAUDE.md (this is a spec repo, so I've focused on documentation consistency, markdown correctness, and change scope rather than "code").

👍 What works well

  • Renaming End of LifeRetirement and fixing the §5.4 body text (previously "The Runtime Operations stage..." under an "Operation and Monitoring" heading) is a real improvement. Importantly, it brings SPEC.md into alignment with FAQ.md, which already uses "Retirement" and "Operation and Monitoring" (e.g. the persona-assignment section and the comparison table). So this satisfies the CLAUDE.md rule that SPEC and FAQ stay consistent — no FAQ change is needed here. ✅
  • The training-scope clarifications ("pre-training, mid-training and post-training", "intermediate & test runs") are useful and non-controversial additions.

🔧 Suggestions / issues

  1. Heading capitalization is now internally inconsistent. §5 headings were changed to sentence case ("AI lifecycle stages", "Design and development", "Operation and monitoring"), but the body text and other headings still use Title Case — e.g. §7.4 is still "Operation and Monitoring (Consumer)" and §7.2 "Design and Development". If the ISO goal is sentence-case headings, §7 (and the persona sections) should be updated too; otherwise §5 now clashes with the rest of the document. Pick one convention and apply it throughout.

  2. Missing blank line before ## 6. (SPEC.md). The blank line between the §5.5 Retirement paragraph and the ## 6. Persona-Based Software Boundary Definition heading was removed. Some Markdown renderers require a blank line before a heading — please restore it.

  3. Trailing whitespace introduced. The blank separator lines in §5 were changed from empty lines to lines containing a single space. Worth making them truly empty to avoid trailing-whitespace noise.

  4. Scope creep vs. the PR title. The PR is titled "Revised the AI lifecycle stages", but it also adds .github/ISSUE_TEMPLATE/agenda.md and rewrites the README "Appointments" section. Per the CLAUDE.md workflow (PRs reviewed in weekly calls), consider splitting these unrelated changes into separate PRs so each can be approved on its own merit.

  5. agenda.md frontmatter looks off. The file starts with ---- (four dashes), then ## ..., then --- (three dashes + trailing space). That is not valid GitHub issue-template YAML frontmatter (which needs --- delimiters with name:/about: fields), so it won't appear as a named template in the issue chooser. Recommend a proper frontmatter block.

  6. Name spellings disagree between the two added/edited files. README says "Navveen Balani" and "Henry Richardson"; agenda.md says "Naveen Balani" and "Henry Richards". Please confirm and use the correct spelling consistently.

  7. README @mentions won't hyperlink. @navveenb / @Henry-WattTime auto-link in issues/PRs/comments but not in a rendered README.md. The previous entry used a proper Markdown link ([Navveen Balani (Accenture)](https://github.com/navveenb)); consider keeping the [Name](https://github.com/handle) form so the links stay clickable.

None of these block the substance of the lifecycle-stage revision — items 1–3 are the ones I'd fix before merge, and 4–7 are mostly scope/hygiene.

@Henry-WattTime

Copy link
Copy Markdown

@navveenb , can you review the change of title from 'retirement' to 'end-of-life'? Do we want that change? Also, the ampersand and test need to be removed. Otherwise approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants