Revised the Terms and definitions to comply with ISO - #137
Conversation
Terms and definitions Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
PR Review — Terms and definitions ISO alignmentThanks for this! Since this is a specification repository (not code), I've framed the review around document correctness, ISO alignment, and rendering. Overall this is a solid, well-scoped change that genuinely improves ISO/IEC conformance. A few points below. 👍 What's good
|
Added definitions for 'gross value' and 'effective value' to the specification. Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
🤖 Claude PR Review — Terms and Definitions (ISO alignment)Reviewed against 👍 What looks good
|
Added a new section on ISO and IEC terminological databases. Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
Removed unnecessary note indicators in definitions for clarity. Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
Removed 'Note 1 to entry:' prefix from examples under gross value. Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
|
Review — #137 Terms and definitions (ISO alignment) Two earlier automated reviews already covered the rendering and whitespace nits, so I verified those claims and focused on what they missed. Net: the clause renumbering is safe and the style shift is right, but there are a few substantive definitional issues worth resolving before merge. Corrections to the earlier reviews
1. Current: The commercial framing (
Since #137 is the PR that ISO-aligns this clause, it is the right place to make the definitions role-based rather than transactional. Suggestion: 2. The new Concrete fix within this PR:
This is also the cross-reference the second review asked for, but resolved by removing the duplicate instead of linking to it. 3. The note on It reads "…described in the Functional Unit clause of ISO/IEC 21031:2024". ISO citation style is numeric — 4. Rendering — one fix that solves two problems Rather than restoring trailing double-spaces (invisible, easily stripped by editors, and re-broken by the next contributor), consider promoting each entry to an H3 heading — a line reading Either way, please also convert the whitespace-only separator lines ( 5. Missing term: Outside this diff, but it is a gap in the clause this PR is finalising: FAQ (per CLAUDE.md)
Process suggestion
Not applicable: performance, security, test coverage (documentation-only change). Summary: items 1 and 2 are worth resolving in this PR — the payment-based persona definitions and the duplicated gross/effective definitions are both things a standards reviewer would send back. Item 4 needs a decision on the target output format. Items 3 and 5 are quick, and 5 could reasonably be deferred. The core change — clause numbering plus ISO term and definition style — is the right direction and cleanly executed. |
|
Review — Clause 4 ISO alignment Reviewed per Two earlier automated reviews are already on this PR. Rather than restate them, I verified their claims and focused on what is still open. Two corrections first:
Confirmed accurate from the earlier reviews: no dangling 🔴 Main issue: 4.1 redefines a term owned by the normative reference Clause 4 opens with "the terms and definitions given in ISO/IEC 21031:2024 and the following apply" — which asserts that 4.1–4.10 are additional terms. But the Note in 4.1 says the concept is already "described in the Functional Unit clause of ISO/IEC 21031:2024." If 21031 defines Worth confirming against the 21031 text, then picking one:
The same question applies more weakly to 4.2/4.3 ( 🟠 Note/example tagging is inconsistent across the three entries with trailing prose
Under ISO/IEC Directives Part 2, everything following a definition in a term entry must be an explicitly labelled 🟠 Vague citation in the 4.1 note
🟠 4.9/4.10 now duplicate the 8.2.2 Explanation block
Defining these in Clause 4 is the right call, but leaving both copies means two sources of truth that will drift at the next revision. Suggest reducing the 8.2.2 block to its genuinely additive final sentence plus a cross-reference: > **Explanation**: See 4.9 (gross value) and 4.10 (effective value).
>
> Reporting *effective* values gives a more realistic picture of efficiency by recognizing
> carbon savings from optimizations like pruning, deduplication, or sparse activations.While in that area: 🟡 Rendering — hard breaks As above, each entry collapses to **4.1**··
**functional unit**··
quantified performance characteristic of an AI system that serves as the reference unit for carbon intensity calculation( 🟡 Cross-PR consistency (PRs 137–142) Not blocking this PR, but flagging since it is a six-PR series all branched from
📄 FAQ sync Per Summary: the direction is right and the mechanical ISO conversion is well executed. Before merge I would fix the hard-break rendering (🟡, quick) and resolve the 4.1 term collision with 21031 (🔴, needs a decision). Note tagging and the 8.2.2 de-duplication are worth folding into the same pass. |
Review: Revised the Terms and definitions to comply with ISO (#137)Thanks for this — moving clause 4 to ISO drafting conventions (sentence-case heading, lowercase term entries, no terminating full stop, 1. Rendering: the hard line breaks were dropped, so each entry collapses onto one line 🔴The previous version used two trailing spaces after the entry number and the term to force line breaks (
That defeats the ISO layout the PR is trying to achieve, and it affects all ten entries ( **4.1**
**functional unit**
quantified performance characteristic of an AI system ...or use 2.
|
|
I think the definition in 4.9 and 4.10 need to be corrected to make sense. |
Signed-off-by: Sean Mcilroy <smcilroy@linuxfoundation.org>
Review: Revised Terms and definitions to comply with ISO (#137)Thanks for this — moving Clause 4 to ISO/IEC Directives Part 2 term-entry style (numbered A few things worth fixing before merge. Since this is a spec repo, I have framed "bugs" as rendering/consistency defects and "tests" as CI checks. 1. Rendering regression: term entries collapse onto one line (blocking)The previous version ended **4.1**
**functional unit**
quantified performance characteristic of an AI system that serves as the reference unit for carbon intensity calculationGitHub renders My suggestion is to make the entries real subclause headings rather than bold text: #### 4.1 functional unit
quantified performance characteristic of an AI system that serves as the reference unit for carbon intensity calculationThat fixes the line-break problem, and as a bonus gives each term a stable anchor ( 2. Whitespace-only "blank" linesThe 14 blank lines added in this clause each contain a single space ( 3.
|
Terms and definitions