Skip to content

Fix W3DView camera division by zero #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix W3DView camera division by zero #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,11 @@ void W3DView::buildCameraTransform( Matrix3D *transform )
// do fxPitch adjustment
if (m_useRealZoomCam)
{
sourcePos.X = targetPos.X + ((sourcePos.X - targetPos.X) / m_FXPitch);
sourcePos.Y = targetPos.Y + ((sourcePos.Y - targetPos.Y) / m_FXPitch);
if (m_FXPitch != 0.0f)
{
sourcePos.X = targetPos.X + ((sourcePos.X - targetPos.X) / m_FXPitch);
sourcePos.Y = targetPos.Y + ((sourcePos.Y - targetPos.Y) / m_FXPitch);
}
}
else
{
Expand All @@ -400,8 +403,11 @@ void W3DView::buildCameraTransform( Matrix3D *transform )
}
else
{
sourcePos.X = targetPos.X + ((sourcePos.X - targetPos.X) / m_FXPitch);
sourcePos.Y = targetPos.Y + ((sourcePos.Y - targetPos.Y) / m_FXPitch);
if (m_FXPitch != 0.0f)
{
sourcePos.X = targetPos.X + ((sourcePos.X - targetPos.X) / m_FXPitch);
sourcePos.Y = targetPos.Y + ((sourcePos.Y - targetPos.Y) / m_FXPitch);
}
}
#endif
}
Expand Down Expand Up @@ -576,7 +582,7 @@ void W3DView::setCameraTransform( void )

if (m_useRealZoomCam) //WST 10.19.2002
{
if (m_FXPitch<0.95f)
if (m_FXPitch<0.95f && m_FXPitch != 0.0f)
{
farZ = farZ / m_FXPitch; //Extend far Z when we pitch up for RealZoomCam
}
Expand Down
Loading