Fix W3DView camera division by zero #278
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-28A. The issue was that: Unchecked division by
m_FXPitchinW3DViewduring shutdown causesINT_DIVIDE_BY_ZEROwhenm_FXPitchis zero.m_FXPitch != 0.0fbefore division operations in camera position calculations.m_FXPitch != 0.0fbefore dividingfarZbym_FXPitch.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 8434525
Not quite right? Click here to continue debugging with Seer.