#1440 [Perf] add: saturne_select_users() with per-request cached user list#1441
Merged
nicolas-eoxia merged 1 commit intoJul 6, 2026
Merged
Conversation
…ed user list Form::select_dolusers() runs its user-list query on every call. Add a helper that fetches the list once per request (select_dolusers outputmode=1) and renders each dropdown with selectarray(), keeping the same name/css so JS selectors still match. Lets pages with many user dropdowns avoid the N queries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1440
Problème
Form::select_dolusers()réexécute sa requête « liste des utilisateurs » à chaque appel. Une page avec beaucoup de sélecteurs utilisateur relance la même requête des dizaines de fois.Solution
saturne_select_users($htmlName, $selected, $showEmpty, $morecss)danslib/saturne_functions.lib.php:select_dolusers(..., outputmode=1)(mise enstatic) ;<select>viaselectarray(), nom + classes CSS conservés (sélecteurs JS inchangés), select2 préservé.Vérification
Premier usage sur la liste des risques Digirisk (PR digirisk associée à #4888) : requête
select_dolusers18 → 1. Sélecteur vérifié en live (Playwright) : 63 utilisateurs, combo select2, présélection correcte, aucune régression.Réutilisable par tous les modules Saturne.
🤖 Generated with Claude Code