#4888 [Risk] rework: use saturne_select_users for executive pickers#4889
Merged
nicolas-eoxia merged 1 commit intoJul 6, 2026
Conversation
…ckers The three executive dropdowns (risk-add modal, task-add modal, task-edit modal) each called select_dolusers(), running the same "all users" query 18x per page. Use the cached saturne_select_users() helper instead: same name/class so risk.js and task.js selectors still match. Cuts select_dolusers queries from 18 to 1. Requires Saturne PR Evarisk#1441 (saturne_select_users) to be merged first. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4888
Problème
Les 3 sélecteurs d'exécutant de la liste des risques (modale ajout risque, ajout tâche, édition tâche) appelaient chacun
select_dolusers()→ la même requête « tous les utilisateurs » exécutée 18× par page (17 doublons, reliquat du profilage #4886).Solution
Utiliser le helper mutualisé
saturne_select_users()(liste mise en cache par requête) à la place deselect_dolusers(), en conservant nom + classes (executive_id,executiveSelect,executiveSelectEdit) →risk.jsettask.jsfonctionnent sans modification.Résultat mesuré
select_dolusers: 18 → 1.Vérification (Playwright)
Sélecteur d'exécutant : 63 utilisateurs, combo select2 actif, présélection correcte (modale édition), rendu pleine largeur — aucune régression. Capture modale « ajouter une tâche » OK.
Nécessite la PR Saturne Evarisk/Saturne#1441 (
saturne_select_users) fusionnée d'abord, sinon fonction indéfinie.🤖 Generated with Claude Code