Harden Termux command validation and shell escaping#4
Open
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Open
Harden Termux command validation and shell escaping#4Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- centralize Termux shell quoting and input validation in TermuxShell\n- validate slugs, relative paths, and required binary names before command construction\n- use centralized shell quoting for all interpolated command values\n- add unit tests for quoting and validation behavior\n\n## Changes\n- add TermuxShell helper\n- harden TermuxSkillSync command and path handling\n- harden ClawHubTermuxSkillAdapter entrypoint and argument handling\n- add TermuxShellTest coverage\n\n## Notes\n- validation is traversal-safe and control-character-safe while remaining compatibility-oriented\n- local Gradle test execution wasn't possible here because Java/JAVA_HOME is missing