Skip to content

Harden Termux command validation and shell escaping#4

Open
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Ridwannurudeen:chore/termux-command-hardening
Open

Harden Termux command validation and shell escaping#4
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Ridwannurudeen:chore/termux-command-hardening

Conversation

@Ridwannurudeen
Copy link

Summary\n- centralize Termux shell quoting and input validation in TermuxShell\n- validate slugs, relative paths, and required binary names before command construction\n- use centralized shell quoting for all interpolated command values\n- add unit tests for quoting and validation behavior\n\n## Changes\n- add TermuxShell helper\n- harden TermuxSkillSync command and path handling\n- harden ClawHubTermuxSkillAdapter entrypoint and argument handling\n- add TermuxShellTest coverage\n\n## Notes\n- validation is traversal-safe and control-character-safe while remaining compatibility-oriented\n- local Gradle test execution wasn't possible here because Java/JAVA_HOME is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant