Harden ClawHub ZIP extraction and Termux command validation#2
Closed
Ridwannurudeen wants to merge 1 commit intoEthereumPhone:mainfrom
Closed
Harden ClawHub ZIP extraction and Termux command validation#2Ridwannurudeen wants to merge 1 commit intoEthereumPhone:mainfrom
Ridwannurudeen wants to merge 1 commit intoEthereumPhone:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- harden ClawHub ZIP extraction against zip-slip and zip-bomb patterns\n- add bounded extraction limits (entry count, entry size, total uncompressed size)\n- centralize Termux shell quoting and validation in a new TermuxShell helper\n- validate slug/path/bin inputs before building Termux shell commands\n- add unit tests for Termux shell validation and ClawHub ZIP security behavior\n\n## Security\n- path containment is enforced using canonical paths with separator-safe checks\n- extraction aborts on suspicious archive structure or size limits\n- Termux command construction now quotes all interpolated values and rejects traversal/control characters\n\n## Testing\n- added TermuxShellTest\n- added ClawHubApiSecurityTest (MockWebServer)\n\n## Notes\n- local Gradle test execution was not run in this environment because Java/JAVA_HOME is missing