Harden ClawHub ZIP extraction and add security tests#3
Open
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Open
Harden ClawHub ZIP extraction and add security tests#3Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Ridwannurudeen wants to merge 2 commits intoEthereumPhone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- harden ClawHub ZIP extraction against zip-slip and zip-bomb patterns\n- enforce bounded extraction limits (entry count, per-entry size, total uncompressed size)\n- add focused security tests for archive handling behavior via public download path\n\n## Changes\n- ClawHubApi.extractZip: canonical path containment + bounded copy with limits\n- add ClawHubApiSecurityTest covering:\n - safe archive extraction\n - zip-slip rejection\n - excessive entry-count rejection\n - oversized entry rejection\n- add test dependency: mockwebserver\n\n## Notes\n- local Gradle execution wasn't possible here because Java/JAVA_HOME is missing