Skip to content

[ci] separate output directory for different fixtures#964

Merged
Jiahui17 merged 15 commits into
mainfrom
fix/jiahui/ci-separate-outDirs-artifact
Jun 5, 2026
Merged

[ci] separate output directory for different fixtures#964
Jiahui17 merged 15 commits into
mainfrom
fix/jiahui/ci-separate-outDirs-artifact

Conversation

@Jiahui17
Copy link
Copy Markdown
Member

@Jiahui17 Jiahui17 commented Jun 4, 2026

Previously, we always reused the same output directory (e.g., fir/out/...) for different test fixtures (e.g., speculation vs. sharing) on the same benchmark, it has two issues:

  1. When tests are parallelized, there might be a race condition between these separate tests on the same benchmark
  2. Github action only uploads artifact for the last run. This is problematic for troubleshooting

This PR deduplicates the output directory for each test fixture

@Jiahui17 Jiahui17 marked this pull request as ready for review June 4, 2026 12:21
@Jiahui17
Copy link
Copy Markdown
Member Author

Jiahui17 commented Jun 4, 2026

image The generated name is a bit long, but this is just for debugging, so it should be fine

@Jiahui17 Jiahui17 changed the title [ci] separate outDir for different fixtures [ci] separate output directory for different fixtures Jun 5, 2026
@Jiahui17 Jiahui17 merged commit 89235ae into main Jun 5, 2026
8 checks passed
@Jiahui17 Jiahui17 deleted the fix/jiahui/ci-separate-outDirs-artifact branch June 5, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant