-
Notifications
You must be signed in to change notification settings - Fork 397
feat(otel): add support for otel metrics #5021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2025-12-02 19:16:04 Comparing candidate commit ac5449b in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
a611845 to
9eb0a24
Compare
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it another pass! I think this is getting in quite good shape :)
a6ddfdc to
bee73bb
Compare
Thanks so much for the thorough review and feedback. I really appreciate your time and patience. I learned a lot about ruby along the way 😸 |
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great to me! I really like how clean the tests ended up :)
Co-authored-by: Ivo Anjo <[email protected]>
vpellan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change for the core/configuration/settings.rb file. Other requested changes are minor, after that it should be good !
b22e40e to
f4c7eab
Compare
What does this PR do?
Adds OpenTelemetry metrics SDK integration with OTLP exporter support for gRPC and HTTP/protobuf protocols.
Motivation:
Enables customers to use the OpenTelemetry Metrics API and export metrics via OTLP to any compatible backend, including the Datadog Agent.
Change log entry
Adds OpenTelemetry metrics SDK integration with OTLP exporter support. Configure via
DD_METRICS_OTEL_ENABLEDand standard OpenTelemetry environment variables.Key Features:
OTEL_EXPORTER_OTLP_*) as defaults for metrics-specific settingsRequired Gems for metrics support:
opentelemetry-metrics-sdk(~> 0.8)opentelemetry-exporter-otlp-metrics(~> 0.4)Testing:
BUNDLE_GEMFILE=gemfiles/ruby_3.2_opentelemetry.gemfile bundle exec rspec spec/datadog/opentelemetry/metrics_spec.rb