Skip to content

Commit b22e40e

Browse files
committed
fix steep checks
1 parent 471fd3a commit b22e40e

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

Steepfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,6 @@ target :datadog do
158158
ignore 'lib/datadog/opentelemetry/api/context.rb'
159159
ignore 'lib/datadog/opentelemetry/api/trace/span.rb'
160160
ignore 'lib/datadog/opentelemetry/sdk/configurator.rb'
161-
ignore 'lib/datadog/opentelemetry/sdk/exporter.rb'
162-
ignore 'lib/datadog/opentelemetry/sdk/metrics_exporter.rb'
163161
ignore 'lib/datadog/opentelemetry/sdk/id_generator.rb'
164162
ignore 'lib/datadog/opentelemetry/sdk/propagator.rb'
165163
ignore 'lib/datadog/opentelemetry/sdk/span_processor.rb'

lib/datadog/opentelemetry/sdk/metrics_exporter.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ def initialize(endpoint:, timeout:, headers:, protocol:)
1616
end
1717

1818
def export(metrics, timeout: nil)
19-
telemetry.inc('tracers', METRIC_EXPORT_ATTEMPTS, 1, tags: @telemetry_tags)
19+
telemetry&.inc('tracers', METRIC_EXPORT_ATTEMPTS, 1, tags: @telemetry_tags)
2020
result = super
2121
metric_name = (result == 0) ? METRIC_EXPORT_SUCCESSES : METRIC_EXPORT_FAILURES
22-
telemetry.inc('tracers', metric_name, 1, tags: @telemetry_tags)
22+
telemetry&.inc('tracers', metric_name, 1, tags: @telemetry_tags)
2323
result
2424
rescue => e
2525
Datadog.logger.error("Failed to export OpenTelemetry Metrics: #{e.class}: #{e}")
26-
telemetry.inc('tracers', METRIC_EXPORT_FAILURES, 1, tags: @telemetry_tags)
26+
telemetry&.inc('tracers', METRIC_EXPORT_FAILURES, 1, tags: @telemetry_tags)
2727
raise
2828
end
2929

sig/datadog/opentelemetry/metrics.rbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module Datadog
1313

1414
def create_resource: () -> untyped
1515

16-
def configure_metric_reader: (untyped provider) -> void
16+
def configure_metric_reader: (::OpenTelemetry::SDK::Metrics::MeterProvider provider) -> void
1717

1818
def resolve_metrics_endpoint: () -> ::String
1919

sig/datadog/opentelemetry/sdk/metrics_exporter.rbs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
module Datadog
22
module OpenTelemetry
33
module SDK
4-
# Inherits from ::OpenTelemetry::Exporter::OTLP::Metrics::MetricsExporter
5-
# but parent class type is not available in RBS
6-
class MetricsExporter
4+
class MetricsExporter < ::OpenTelemetry::Exporter::OTLP::Metrics::MetricsExporter
75
@telemetry_tags: ::Hash[::String, ::String]
86

97
METRIC_EXPORT_ATTEMPTS: "otel.metrics_export_attempts"
@@ -12,7 +10,7 @@ module Datadog
1210

1311
METRIC_EXPORT_FAILURES: "otel.metrics_export_failures"
1412

15-
def initialize: (endpoint: ::String, timeout: ::Float, headers: ::Hash[untyped, untyped], protocol: ::String) -> untyped
13+
def initialize: (endpoint: ::String, timeout: ::Float, headers: ::Hash[::String, any], protocol: ::String) -> void
1614

1715
def export: (untyped metrics, ?timeout: ::Float?) -> Integer
1816

0 commit comments

Comments
 (0)