Fix TextPacket.needsTranslation not being preserved across deserializ… - #339
Merged
PetteriM1 merged 1 commit intoJul 17, 2026
Merged
Conversation
…e/re-serialize All TextSerializer deserialize() methods read needsTranslation from the buffer but never call packet.setNeedsTranslation(), causing it to default to false on re-serialization. Fix: add packet.setNeedsTranslation(needsTranslation) after reading the boolean in v291, v332, v554, v898, and v924. v685 inherits from v554.
onebeastchris
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TextPacket.needsTranslation not preserved across deserialize/re-serialize
Summary
All TextSerializer deserialize() methods read needsTranslation from the wire but never store it back to the packet object. After deserialization, packet.isNeedsTranslation() always returns false, regardless of what the server actually sent.
This causes translation keys (e.g. %multiplayer.player.joined) to be incorrectly tagged as needsTranslation=false when the packet passes through any proxy that deserializes and re-serializes it.
Fix
Added packet.setNeedsTranslation(needsTranslation) after buffer.readBoolean() in: