Skip to content

Commit f349f3d

Browse files
authored
Fix TextPacket.needsTranslation not being preserved across deserialize/re-serialize (#339)
1 parent f8295d3 commit f349f3d

5 files changed

Lines changed: 5 additions & 0 deletions

File tree

bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v291/serializer/TextSerializer_v291.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket pa
5454
packet.setType(type);
5555
TextConverter converter = helper.getTextConverter();
5656
boolean needsTranslation = buffer.readBoolean();
57+
packet.setNeedsTranslation(needsTranslation);
5758

5859
switch (type) {
5960
case CHAT:

bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v332/serializer/TextSerializer_v332.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket pa
5858
packet.setType(type);
5959
TextConverter converter = helper.getTextConverter();
6060
boolean needsTranslation = buffer.readBoolean();
61+
packet.setNeedsTranslation(needsTranslation);
6162

6263
switch (type) {
6364
case CHAT:

bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v554/serializer/TextSerializer_v554.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket pa
5656
packet.setType(type);
5757
TextConverter converter = helper.getTextConverter();
5858
boolean needsTranslation = buffer.readBoolean();
59+
packet.setNeedsTranslation(needsTranslation);
5960

6061
switch (type) {
6162
case CHAT:

bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v898/serializer/TextSerializer_v898.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ public void serialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket pack
116116
public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket packet) {
117117
TextConverter converter = helper.getTextConverter();
118118
boolean needsTranslation = buffer.readBoolean();
119+
packet.setNeedsTranslation(needsTranslation);
119120

120121
switch (buffer.readByte()) {
121122
case 0: // MessageOnly

bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v924/serializer/TextSerializer_v924.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ public void serialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket pack
9898
public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, TextPacket packet) {
9999
TextConverter converter = helper.getTextConverter();
100100
boolean needsTranslation = buffer.readBoolean();
101+
packet.setNeedsTranslation(needsTranslation);
101102

102103
switch (buffer.readByte()) {
103104
case 0: // MessageOnly

0 commit comments

Comments
 (0)