Skip to content

Fix: Calculation of PostgreSQL bloat and output to schema.table #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
britiger wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −7
Open

Fix: Calculation of PostgreSQL bloat and output to schema.table #890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebbceb2
Fix bug in postgresql table bloat calculation
britiger Jan 28, 2026
d74dd1b
Output full table and index names for postgresql
britiger Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions cmk/base/legacy_checks/postgres_bloat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,17 @@ def check_postgres_bloat(item, params, parsed):
index_abs_total = 0

show_levels = False
last_tablename = ""
for line in database:
tbloat = float(line["tbloat"])
twasted = int(line["wastedbytes"])
ibloat = float(line["ibloat"])
iwasted = int(line["wastedibytes"])

table_abs_total += twasted
if line["schemaname"] + "." + line["tablename"] != last_tablename:
table_abs_total += twasted
index_abs_total += iwasted
last_tablename = line["schemaname"] + "." + line["tablename"]

# Calculate highest loss
if not table_perc_max or tbloat > float(table_perc_max["tbloat"]):
Expand All @@ -77,18 +80,19 @@ def check_postgres_bloat(item, params, parsed):
if "%s_bloat_perc" % what in params:
warn, crit = params["%s_bloat_perc" % what]
if bloat >= crit:
yield 2, "{} {} bloat: {}% (too high)".format(line["tablename"], what, bloat)
yield 2, "{}.{} {} bloat: {}% (too high)".format(line["schemaname"], line["tablename"], what, bloat)
show_levels = True
elif bloat >= warn:
yield 1, "{} {} bloat: {}% (too high)".format(line["tablename"], what, bloat)
yield 1, "{}.{} {} bloat: {}% (too high)".format(line["schemaname"], line["tablename"], what, bloat)
show_levels = True

if "%s_bloat_abs" % what in params:
warn, crit = params["%s_bloat_abs" % what]
if wasted >= crit:
yield (
2,
"{} wasted {} bytes: {} (too high)".format(
"{}.{} wasted {} bytes: {} (too high)".format(
line["schemaname"],
line["tablename"],
what,
render.bytes(wasted),
Expand All @@ -98,7 +102,8 @@ def check_postgres_bloat(item, params, parsed):
elif wasted >= warn:
yield (
1,
"{} wasted {} bytes: {} (too high)".format(
"{}.{} wasted {} bytes: {} (too high)".format(
line["schemaname"],
line["tablename"],
what,
render.bytes(wasted),
Expand Down Expand Up @@ -130,16 +135,18 @@ def check_postgres_bloat(item, params, parsed):
]:
yield (
0,
"Maximum {} bloat at {}: {}".format(
"Maximum {} bloat at {}.{}: {}".format(
what,
perc_max["schemaname"],
perc_max["tablename"],
render.percent(float(perc_max["%sbloat" % what[0]])),
),
)
yield (
0,
"Maximum wasted {}space at {}: {}".format(
"Maximum wasted {}space at {}.{}: {}".format(
what,
abs_max["schemaname"],
abs_max["tablename"],
render.bytes(int(abs_max["wasted%sbytes" % (what == "index" and "i" or "")])),
),
Expand Down