Fix: Calculation of PostgreSQL bloat and output to schema.table #890
+14
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
This PR fixes a bug in calculation of table bloat in PostgreSQL. As described in the community forum there is a bug. The agent plugin mk_postgres.py returns one table with all bloat values for tables and indexes. If a table has more than one index it also increased the bloat for this table multiple times. In some cases the reported wasted table size is bigger than the table itself.
Also the output of index and tablenames if in state WARN or CRIT are without schema. Within a database the tablename is not unique.
Proposed changes
Change the calculation and output in
postgres_bloat: