Refine THI method guidance and caveats#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refines livestock THI method guidance, source-support notes, and user-facing caveats across code, docs, and CLI/report output.
Problem / Motivation
Issue
#30was no longer a blank method-design issue, but repo still lacked a clean public THI method description, explicit threshold caveats, and consistent output wording about what THI results do and do not mean.Without this, users could read THI summaries as more certain or more breed-resolved than toolkit can currently support.
Scope
era_5and projected humidity limitsera_5Implementation Notes
describe_thi_method()to expose formula, threshold basis, climate-profile logic, interpretation caveats, and source-support status.era_5marked uncertain because current operational fetch config does not define humidity band for THI workflow.Data / Access / Runtime Notes
nex_gddpTHI remains conditional onhursavailability.era_5THI still not promoted to supported default path.Testing
tests/test_thi.pytests/test_statistics_source_policy.py.venv/bin/python -m pytest -q tests/test_thi.py tests/test_statistics_source_policy.py tests/test_compare_periods_baseline.py tests/test_hazard_thresholds.pyReviewer Guidance
Focus review on:
climate_tookit/climatology/heat_stress.pyclimate_tookit/climate_statistics/statistics.pyclimate_tookit/season_analysis/seasons.pyclimate_tookit/compare_periods/periods.pyclimate_tookit/calculate_hazards/hazards.pydocs/thi_workflow.mdRelated Issues
#30#9Checklist