Recover subject name when called with pcall to get proper error messages#102
Open
RaphaelIT7 wants to merge 2 commits intoCFC-Servers:mainfrom
Open
Recover subject name when called with pcall to get proper error messages#102RaphaelIT7 wants to merge 2 commits intoCFC-Servers:mainfrom
RaphaelIT7 wants to merge 2 commits intoCFC-Servers:mainfrom
Conversation
9ce7b8f to
75841f5
Compare
sarahsturgeon
requested changes
Apr 7, 2026
Member
sarahsturgeon
left a comment
There was a problem hiding this comment.
I want to give this some more thought to figure out if this is the right way (or best short-term way) to approach this. Regardless, if we do go this way, I'd like to see some LuaLS typedocs for these functions. They're complex enough that having annotations could really help the reader understand.
0447514 to
b5074cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disastrous abomination of unholy code solves the current issue CFC-Servers/gmod_tests#25 is having
When you pass a function to pcall that will error directly, Lua has no idea what the name of it is, causing the error message to include '?' instead of for example 'Left'
This tries to fix that issue, it's bad, but it works really well in my testing.
And no, simply using debug.getinfo to get the name does not work, as the name will not be set for the subject so I fell back to reading the file to figure out the name :/
There probably is a better way, though this is the best that I came up, it may be a disaster, but it's a functional one :3