Recover subject name when called with pcall to get proper error messages

Author: RaphaelIT7

lua/gluatest/expectations/negative.lua

@@ -178,6 +178,7 @@ return function( subject, ... )
     function expectations.succeed()
         assert( TypeID( subject ) == TYPE_FUNCTION, ".succeed expects a function" )
 
+        jit.off( subject, false )
         local success = pcall( subject, unpack( args ) )
 
         if success ~= false then
@@ -189,6 +190,7 @@ return function( subject, ... )
     function expectations.err()
         assert( TypeID( subject ) == TYPE_FUNCTION, ".err expects a function" )
 
+        jit.off( subject, false )
         local success = pcall( subject, unpack( args ) )
 
         if success ~= true then
@@ -202,6 +204,7 @@ return function( subject, ... )
         assert( TypeID( subject ) == TYPE_FUNCTION, ".errWith expects a function" )
         assert( isstring( comparison ), "errWith expects a string" )
 
+        jit.off( subject, false )
         local success, err = pcall( subject, unpack( args ) )
 
         if success == true then

lua/gluatest/expectations/positive.lua

@@ -177,6 +177,7 @@ return function( subject, ... )
     function expectations.succeed()
         assert( TypeID( subject ) == TYPE_FUNCTION, ".succeed expects a function" )
 
+        jit.off( subject, false )
         local success, err = pcall( subject, unpack( args ) )
 
         if success == false then
@@ -188,6 +189,7 @@ return function( subject, ... )
     function expectations.err()
         assert( TypeID( subject ) == TYPE_FUNCTION, ".err expects a function" )
 
+        jit.off( subject, false )
         local success = pcall( subject, unpack( args ) )
 
         if success == true then
@@ -201,6 +203,7 @@ return function( subject, ... )
         assert( TypeID( subject ) == TYPE_FUNCTION, ".errWith expects a function" )
         assert( TypeID( comparison ) == TYPE_STRING, ".errWith expects a string" )
 
+        jit.off( subject, false )
         local success, err = pcall( subject, unpack( args ) )
 
         if success == true then

lua/tests/gluatest/expectations/callerRecovery.lua

@@ -0,0 +1,17 @@
+---@diagnostic disable: param-type-mismatch
+return {
+    groupName = "callerRecovery",
+    cases = {
+        {
+            name = "Called function name is included in error message",
+            func = function()
+                -- This never worked, instead of 'Left' it had given '?'
+                expect( string.Left, nil ).to.errWith( "bad argument #1 to 'Left' (string expected, got nil)" )
+
+                -- This is how it always had worked fine
+                local testFunc = function() string.Left( nil, nil ) end
+                expect( testFunc ).to.errWith( "bad argument #1 to 'Left' (string expected, got nil)" )
+            end
+        }
+    }
+}