Skip to content

Remove uneeded copy of bytes in NDJsonWriter #53966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove uneeded copy of bytes in NDJsonWriter #53966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c37cf
Avoid unneeded resizes of List when adding from a Batch<LogRecord>
agehrke Nov 16, 2025
283109b
Remove uneeded mem copy in NDJsonWriter
agehrke Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/LogsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ internal static class LogsHelper

internal static (List<TelemetryItem> TelemetryItems, TelemetrySchemaTypeCounter TelemetrySchemaTypeCounter) OtelToAzureMonitorLogs(Batch<LogRecord> batchLogRecord, AzureMonitorResource? resource, string instrumentationKey)
{
List<TelemetryItem> telemetryItems = new List<TelemetryItem>();
List<TelemetryItem> telemetryItems = new List<TelemetryItem>(capacity: (int)batchLogRecord.Count);
var telemetrySchemaTypeCounter = new TelemetrySchemaTypeCounter();
TelemetryItem telemetryItem;

Expand Down
25 changes: 13 additions & 12 deletions sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/NDJsonWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

using System;
using System.IO;
using System.Buffers;
using System.Text.Json;

namespace Azure.Monitor.OpenTelemetry.Exporter.Internals
Expand All @@ -11,39 +11,40 @@ internal sealed class NDJsonWriter : IDisposable
{
private static readonly byte[] s_separator = { (byte)'\n' };

private readonly Azure.Core.ArrayBufferWriter<byte> _buffer = new();

public NDJsonWriter()
{
Stream = new MemoryStream();
JsonWriter = new Utf8JsonWriter(Stream, new JsonWriterOptions() { SkipValidation = true });
JsonWriter = new Utf8JsonWriter(_buffer, new JsonWriterOptions() { SkipValidation = true });
}

private MemoryStream Stream { get; }
public Utf8JsonWriter JsonWriter { get; }

public void WriteNewLine()
{
JsonWriter.Flush();
JsonWriter.Reset();
Stream.Write(s_separator, 0, 1);
_buffer.Write(s_separator);
}

public Memory<byte> ToBytes()
public ReadOnlyMemory<byte> ToBytes()
{
JsonWriter.Flush();
return Stream.ToArray();
return _buffer.WrittenMemory;
}

public override string ToString()
{
Stream.Position = 0;
using var streamReader = new StreamReader(Stream);
return streamReader.ReadToEnd();
#if NET8_0_OR_GREATER
return System.Text.Encoding.UTF8.GetString(_buffer.WrittenSpan);
#else
return System.Text.Encoding.UTF8.GetString(_buffer.WrittenSpan.ToArray());
#endif
}

public void Dispose()
{
Stream?.Dispose();
JsonWriter?.Dispose();
JsonWriter.Dispose();
}
}
}
Loading