Remove uneeded copy of bytes in NDJsonWriter #53966
Open
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agehrke
requested review from
harsimar,
mattsains-msft,
rajkumar-rangaraj and
xiang17
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @agehrke! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
NDJsonWriterclass is used for serializingTelemetryItemobjects when exporting to Azure Monitor viaApplicationInsightsRestClient. TheNDJsonWriterwrites to aMemoryStream, and copies bytes from the stream via aToArray()call when returning to consumer. This is unneeded. This PR changesNDJsonWriterclass to use Azure.Core's copy ofArrayBufferWriterand just returnsWrittenMemoryto the consumer and avoids the mem copy.Also, when exporting OpenTelemetry logs in
AzureMonitorLogExporterwe use the size ofBatch<LogRecord>when converting them to aList<TelemetryItem>inLogsHelper.OtelToAzureMonitorLogs()