Separate tools and tests - #10
Merged
Merged
Conversation
Contributor
Walkthrough从 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 分钟 需要额外关注的点:
诗篇
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
tool/CMakeLists.txt (1)
86-86: 消息文本混用语言。状态消息使用中文,而代码其余部分为英文。建议统一为英文以符合国际化开发规范。
- message(STATUS "hikcamera 未检测到,跳过相关构建") + message(STATUS "hikcamera not found, skipping related builds")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
test/CMakeLists.txt(0 hunks)tool/CMakeLists.txt(1 hunks)
💤 Files with no reviewable changes (1)
- test/CMakeLists.txt
🔇 Additional comments (1)
tool/CMakeLists.txt (1)
4-5: C++23 标准支持验证。C++23 是最新的 C++ 标准,某些编译器/平台可能不完全支持。请确认目标平台(特别是 ROS 2 支持的编译工具链)能够支持此标准。
heyeuu
pushed a commit
that referenced
this pull request
Dec 15, 2025
…-and-tool Separate tools and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将工具和测试分离,减少自动化测试的构建时间并方便开发人员平时使用工具应用
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.