Skip to content

Tiny fix SaXAudio #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DV666 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tiny fix SaXAudio #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07fbab1
Fix looping sounds when changing fields.
DV666 May 13, 2026
34b06dc
Use SoLoud instead of SdLib when switching the Backend parameter in l…
DV666 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Assembly-CSharp/Global/Sound/SaXAudio/SdLibAPIWithSaXAudio.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,10 @@ public override Int32 SdSoundSystem_SoundCtrl_Start(Int32 soundID, Int32 offsetT
return 0;
}

// [DV] Fix looping sounds when re-using the same sound between fields, mostly for ambiant sounds (eg: Prima Vista machines)
if (bankData.TryGetValue(bankID, out BankData data) && data.LoopEnd > 0)
SaXAudio.SetLooping(soundID, true);

return SaXAudio.StartAtTime(soundID, offsetTimeMSec / 1000f) ? 1 : 0;
}

Expand Down
4 changes: 2 additions & 2 deletions Assembly-CSharp/Global/ff9/Snd/FF9Snd.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ public static Int32 GetExtEnvObjNo(Int32 ObjNo)
{
return 642;
}
if (ObjNo == 255)
{
if (ObjNo == 255) // [DV] Special case for Prima Vista (field 57 and 58). The only sound invoked here is 255 but the devs add a little fix to add 618 and 410.
{ // More informations in SetSfxResDelegate.
return 618;
}
if (ObjNo == 355)
Expand Down
2 changes: 1 addition & 1 deletion Memoria.Launcher/Launcher/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public partial class MainWindow : Window, INotifyPropertyChanged
["SwordplayAssistance", "_swordplayassistance", "SwordplayAssistance", "Hacks", 1, 2, 1],
["FrogCatchingIncrement", "_frogcatchingincrement", "FrogCatchingIncrement", "Hacks", 1, 100, 1],

["AudioBackend", "_audiobackend", "Backend", "Audio", 0, 1, 1],
["AudioBackend", "_audiobackend", "Backend", "Audio", 2, 1, 1],
["WorldSmoothTexture", "_worldsmoothtexture", "WorldSmoothTexture", "Graphics", 0, 1, 1],
["BattleSmoothTexture", "_battlesmoothtexture", "BattleSmoothTexture", "Graphics", 0, 1, 1],
["ElementsSmoothTexture", "_elementssmoothtexture", "ElementsSmoothTexture", "Graphics", 0, 1, 1],
Expand Down