Highlight Git subcommands - #980
Open
Iamliuxiaozhen wants to merge 1 commit into
Open
Conversation
Member
|
While Also this doesn't handle the case of command flags before the subcommand (consider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds minimal semantic highlighting for Git subcommands in the main highlighter.
Currently,
gititself is highlighted as a valid command, but the following subcommand is not checked:With this change:
known Git subcommands are highlighted as command
unknown Git subcommands are highlighted as unknown-token
the Git subcommand list is loaded lazily and cached
external git-* commands are also considered
Scope
This is intentionally limited to the simple form:
git
It does not yet handle:
git -C repo status
git --git-dir=.git status
git -c key=value status
It also does not validate subcommand arguments or options.
Tests
Adds coverage for valid and invalid Git subcommands.