Skip to content

[fix] show invalid feedback #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[fix] show invalid feedback #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0024c24
[chore] add failing tests
bastian-wattro Aug 19, 2025
ecb4f2b
[fix] display invalid feedback
bastian-wattro Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/django_bootstrap5/templates/django_bootstrap5/field_errors.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{% if field_errors %}
<div id="{{ field.auto_id }}_error">
<div class="is-invalid"></div>
{% for text in field_errors %}
<div class="invalid-feedback">{{ text }}</div>
{% endfor %}
Expand Down
1 change: 1 addition & 0 deletions tests/test_bootstrap_field_input_checkbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def test_input_type_checkbox_is_invalid(self):
'<input class="form-check-input is-invalid" id="id_test" name="test" required type="checkbox">'
'<label class="form-check-label" for="id_test">Test</label>'
'<div id="id_test_error">'
'<div class="is-invalid"></div>'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
Expand Down
2 changes: 2 additions & 0 deletions tests/test_bootstrap_field_input_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def test_input_type_text(self):
'<input type="text" name="test"'
' class="form-control is-invalid" placeholder="Test" required id="id_test">'
'<div id="id_test_error">'
'<div class="is-invalid"></div>'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
Expand Down Expand Up @@ -202,6 +203,7 @@ def test_input_validation_failure(self):
'<input type="text" name="test" minlength="1" class="form-control'
' is-invalid" placeholder="Test" required id="id_test">'
'<div id="id_test_error">'
'<div class="is-invalid"></div>'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
Expand Down