Point ZIP and protocol-spec references at zips.z.cash - #13
Open
bloxster wants to merge 1 commit into
Open
Conversation
The .rst sources under zips/blob/master/ no longer exist, so 11 distinct targets (26 occurrences) return 404. Two further references pointed at a zips PR-files view and an issue thread rather than a specification. All now use the canonical zips.z.cash pages; every replacement returns 200. Section numbers in the surrounding prose are unchanged and unverified against the current specification: that needs a content review, not a link fix. Also strips one pre-existing trailing space on a line this already touches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zipsrepository was reorganised and the.rstsources these links point at no longer exist, so 11 distinct targets (26 occurrences) return 404 — including every link to the protocol specification PDF.Every ZIP referenced here has a canonical page on zips.z.cash, the maintained home for the specifications:
Affected: ZIPs 32, 143, 200, 201, 202, 203, 206, 208, 243, 308, and the protocol specification PDF. Each replacement URL was checked and returns 200.
Two further references were pointing at GitHub rather than a specification —
addresses.rstcited ZIP 209 as a pull request files view, andwallet_threat_model.mdcited ZIP 307 as an issue thread. Neither is a 404, but both now usezips.z.cash/zip-0209andzips.z.cash/zip-0307so that no ZIP reference in the tree points at the repository any more.What this does not do. The surrounding prose is untouched. Section references like "Protocol Section 7.7" still point at the current specification PDF, which moves — they are as approximate now as they were when the old link tracked the
zipsmaster branch. Reconciling them needs a content review rather than a link fix, and I did not want to smuggle that into a mechanical change.Also strips one pre-existing trailing space on a line this already touches, so the diff passes
git diff --check.