feat: Game Protocol 15.24

[jprzimba]

This update contains the new game protocol 15.24

Note: Need to update new map, monsters and npcs in future

• Spell Opacity
• Multi-Action Button
• Bounty Tasks
• Weekly Tasks
• Delivery Tasks
• Bounty Talisman System
• New Outfits
• New Mounts
• New Items
• Multi-Offline Training
• New Ambient effects
• 4 News Proficiency Bonus
• Weapon Attack animation
• Soulseals in Soulpit

New Hunts (Need map update)

• Adaean Crystal Mines
• Adaean Shore
• Adaean Silver Mines
• Arean Outskirts
• Bloodfire Gorge
• Inner Crypt
• Isle of Ada
• Outer Crypt
• Stag Bastion
• Unhallowed Crypt

NOTE:

• You can edit client in 15.24 localhost/conf/config.ini file

Downlaod Client

Client 15.24

[htc16]

When training in bed, the button for fist fighting is not working.

All other skillbuttons work though.

[baerlix]

The mechanics of the "weekly tasks" in the "any creature" section involve killing any type of creature, correct?

When you enter a boss room, let's say, for example, Ratmiral, it spawns creatures that increase the boss's difficulty or are simply for spamming. I, for example, have "Tibianus."

But this monster's characteristics are as follows:

local mType = Game.createMonsterType("Tibianus")
local monster = {}

monster.description = "Tibianus"
monster.experience = 0
monster.outfit = {
	lookType = 217,
	lookHead = 0,
	lookBody = 0,
	lookLegs = 0,
	lookFeet = 0,
	lookAddons = 0,
	lookMount = 0,
}

monster.health = 2000
monster.maxHealth = 2000
monster.race = "blood"
monster.corpse = 0
monster.speed = 100
monster.manaCost = 0

monster.changeTarget = {
	interval = 4000,
	chance = 10,
}

What does it mean? It means it doesn't belong to any "raceId" or "bestiary".
Therefore, it shouldn't count as a "kill" in the "weekly task" of "any creature". However, it does.

To fix it, I solved it by editing:
"ioweeklytasks.cpp"
void IOWeeklyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {

I changed:

	// Update "any creature" counter
	if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
		weeklyData.anyCreatureCurrentKills += kills;
		updated = true;

		if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
			weeklyData.completedKillTasks++;
			player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
			player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
			recalculateWeeklyRewardValues(player);
		}
	}

to:

	const auto mtype = g_monsters().getMonsterTypeByRaceId(raceId);
	const auto &bestiaryList = g_game().getBestiaryList();

	bool validBestiaryCreature = mtype
		&& mtype->info.experience > 0
		&& mtype->info.isPreyable
		&& !mtype->info.isPreyExclusive
		&& bestiaryList.find(raceId) != bestiaryList.end(); // debe existir en el bestiary

	if (validBestiaryCreature) {
		if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
			weeklyData.anyCreatureCurrentKills += kills;
			updated = true;

			if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
				weeklyData.completedKillTasks++;
				player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
				player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
				recalculateWeeklyRewardValues(player);
			}
		}
	}

And this was the result

NOTE:
Just ignore that it gives me two points per creature. I set it to give 2 per creature

[htc16]

I want to add that when training axe fighting in bed it seems to train sword fighting instead.

Also, when eating food the icon for hunger don't go away and foodcounter says 00:00 no matter how much you eat.

[jprzimba]

The mechanics of the "weekly tasks" in the "any creature" section involve killing any type of creature, correct?

When you enter a boss room, let's say, for example, Ratmiral, it spawns creatures that increase the boss's difficulty or are simply for spamming. I, for example, have "Tibianus."

But this monster's characteristics are as follows:

local mType = Game.createMonsterType("Tibianus")
local monster = {}

monster.description = "Tibianus"
monster.experience = 0
monster.outfit = {
	lookType = 217,
	lookHead = 0,
	lookBody = 0,
	lookLegs = 0,
	lookFeet = 0,
	lookAddons = 0,
	lookMount = 0,
}

monster.health = 2000
monster.maxHealth = 2000
monster.race = "blood"
monster.corpse = 0
monster.speed = 100
monster.manaCost = 0

monster.changeTarget = {
	interval = 4000,
	chance = 10,
}

What does it mean? It means it doesn't belong to any "raceId" or "bestiary". Therefore, it shouldn't count as a "kill" in the "weekly task" of "any creature". However, it does.

To fix it, I solved it by editing: "ioweeklytasks.cpp" void IOWeeklyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {

I changed:

	// Update "any creature" counter
	if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
		weeklyData.anyCreatureCurrentKills += kills;
		updated = true;

		if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
			weeklyData.completedKillTasks++;
			player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
			player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
			recalculateWeeklyRewardValues(player);
		}
	}

to:

	const auto mtype = g_monsters().getMonsterTypeByRaceId(raceId);
	const auto &bestiaryList = g_game().getBestiaryList();

	bool validBestiaryCreature = mtype
		&& mtype->info.experience > 0
		&& mtype->info.isPreyable
		&& !mtype->info.isPreyExclusive
		&& bestiaryList.find(raceId) != bestiaryList.end(); // debe existir en el bestiary

	if (validBestiaryCreature) {
		if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
			weeklyData.anyCreatureCurrentKills += kills;
			updated = true;

			if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
				weeklyData.completedKillTasks++;
				player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
				player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
				recalculateWeeklyRewardValues(player);
			}
		}
	}

And this was the result

NOTE: Just ignore that it gives me two points per creature. I set it to give 2 per creature

will change, thank you

[baerlix]

Recommendation:
Add a "configKey" to the configmanager:

config_enums.hpp:

	WEEKLY_TASKS_ENABLED,
	WEEKLY_TASKS_RESET_DAY,
	WEEKLY_TASKS_KILL_MULTIPLIER,
};

	BOUNTY_TASKS_REROLL_MULTIPLIER,
	BOUNTY_TASKS_KILL_MULTIPLIER,
	WEEKLY_TASKS_ENABLED,

configmanager.cpp

	loadIntConfig(L, MAX_EXIVA_WHITELIST, "maxExivaWhitelist", 100);
	loadIntConfig(L, WEEKLY_TASKS_KILL_MULTIPLIER, "weeklyTasksKillMultiplier", 1);

	loadIntConfig(L, BOUNTY_TASKS_REROLL_MULTIPLIER, "bountyTasksRerollMultiplier", 1);
	loadIntConfig(L, BOUNTY_TASKS_KILL_MULTIPLIER, "bountyTasksKillMultiplier", 1);
	loadIntConfig(L, TASK_HUNTING_BONUS_REROLL_PRICE, "taskHuntingBonusRerollPrice", 1);

config.lua.dist

weeklyTasksEnabled = true
weeklyTasksResetDay = "monday"
weeklyTasksKillMultiplier = 1

bountyTasksRerollMultiplier = 1
bountyTasksFreeRerollTime = 20 * 60 * 60
bountyTasksKillMultiplier = 1

In order to avoid this type of bug later:

The player completes the weekly quest for a creature ending in "odd," gets one or more kills, and the counter turns orange because it has a limit (for example, 56/55). It should turn green and automatically to (55/55).

This could happen, for example, when a Knight is surrounded by creatures and kills them all at once; they would be awarded all the kills at once.

I solved it by editing for "any creature":
ioweeklytask.cpp

void IOWeeklyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {
	if (!player) {
		return;
	}

	if (!g_configManager().getBoolean(WEEKLY_TASKS_ENABLED)) {
		return;
	}

	auto &weeklyData = player->getWeeklyTaskData();
	bool updated = false;

	// Update "any creature" counter
	const auto mtype = g_monsters().getMonsterTypeByRaceId(raceId);
	const auto &bestiaryList = g_game().getBestiaryList();

	bool validBestiaryCreature = mtype
		&& mtype->info.experience > 0
		&& mtype->info.isPreyable
		&& !mtype->info.isPreyExclusive
		&& bestiaryList.find(raceId) != bestiaryList.end();

	if (validBestiaryCreature) {
		if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
			weeklyData.anyCreatureCurrentKills += kills;
			updated = true;

			if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
				weeklyData.completedKillTasks++;
				player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
				player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
				recalculateWeeklyRewardValues(player);
			}
		}
	}

to:

void IOWeeklyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {
    if (!player) {
        return;
    }

    if (!g_configManager().getBoolean(WEEKLY_TASKS_ENABLED)) {
        return;
    }

    uint32_t kills = g_configManager().getNumber(WEEKLY_TASKS_KILL_MULTIPLIER);

    auto &weeklyData = player->getWeeklyTaskData();
    bool updated = false;

    // Update "any creature" counter
    if (weeklyData.anyCreatureCurrentKills < weeklyData.anyCreatureTotalKills) {
        weeklyData.anyCreatureCurrentKills = std::min(
            weeklyData.anyCreatureCurrentKills + kills,
            (uint32_t)weeklyData.anyCreatureTotalKills
        );
        updated = true;

        if (weeklyData.anyCreatureCurrentKills >= weeklyData.anyCreatureTotalKills) {
            weeklyData.completedKillTasks++;
            player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);
            player->sendTextMessage(MESSAGE_STATUS, "You have completed the weekly 'any creature' kill task!");
            recalculateWeeklyRewardValues(player);
        }
    }

and to "specific creature":

	// Update specific creature tasks
	for (auto &task : weeklyData.killTasks) {
		if (task.raceId == raceId && task.currentKills < task.totalKills) {
			task.currentKills++;
			updated = true;
			if (task.currentKills >= task.totalKills) {
				weeklyData.completedKillTasks++;

				// Grant exp immediately per completed task (real Tibia behavior)
				player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);

				player->sendTextMessage(MESSAGE_STATUS, "You have completed a weekly kill task!");
				recalculateWeeklyRewardValues(player);
				player->refreshTaskIcons();
			}
			break;
		}
	}

to:

	// Update specific creature tasks
	for (auto &task : weeklyData.killTasks) {
        if (task.raceId == raceId && task.currentKills < task.totalKills) {
            task.currentKills = std::min(
                task.currentKills + kills,
                (uint32_t)task.totalKills
            );
			updated = true;
			if (task.currentKills >= task.totalKills) {
				weeklyData.completedKillTasks++;

				// Grant exp immediately per completed task (real Tibia behavior)
				player->addExperience(nullptr, weeklyData.killTaskRewardExp, false);

				player->sendTextMessage(MESSAGE_STATUS, "You have completed a weekly kill task!");
				recalculateWeeklyRewardValues(player);
				player->refreshTaskIcons();
			}
			break;
		}
	}

results:

It prevents the number of deaths from exceeding the allowed limit.

EDIT: For add same feature to "bounty task"
Same thing for "bounty task"?
(I've not tested yet!)

but here the change:

void IOBountyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {
	if (!player) {
		return;
	}

	if (!g_configManager().getBoolean(BOUNTY_TASKS_ENABLED)) {
		return;
	}

	auto &bountyData = player->getBountyTaskData();
	if (bountyData.state != BOUNTY_STATE_ACTIVE) {
		return;
	}

	if (bountyData.activeTask.raceId != raceId) {
		return;
	}

	bountyData.activeTask.currentKills++;

	if (bountyData.activeTask.currentKills >= bountyData.activeTask.requiredKills) {
		bountyData.state = BOUNTY_STATE_COMPLETED;
		player->sendTextMessage(MESSAGE_STATUS, "You have completed your bounty task! Claim your reward.");
	}

	player->sendBountyTaskData();
}

to:

void IOBountyTasks::onCreatureKill(const std::shared_ptr<Player> &player, uint16_t raceId) {
	if (!player) {
		return;
	}

	if (!g_configManager().getBoolean(BOUNTY_TASKS_ENABLED)) {
		return;
	}

	auto &bountyData = player->getBountyTaskData();
	if (bountyData.state != BOUNTY_STATE_ACTIVE) {
		return;
	}

	if (bountyData.activeTask.raceId != raceId) {
		return;
	}

	uint32_t kills = g_configManager().getNumber(BOUNTY_TASKS_KILL_MULTIPLIER);

	bountyData.activeTask.currentKills = std::min(
    bountyData.activeTask.currentKills + kills,
    (uint32_t)bountyData.activeTask.requiredKills
	);

	if (bountyData.activeTask.currentKills >= bountyData.activeTask.requiredKills) {
		bountyData.state = BOUNTY_STATE_COMPLETED;
		player->sendTextMessage(MESSAGE_STATUS, "You have completed your bounty task! Claim your reward.");
	}

	player->sendBountyTaskData();
}

[jprzimba]

I want to add that when training axe fighting in bed it seems to train sword fighting instead.

Also, when eating food the icon for hunger don't go away and foodcounter says 00:00 no matter how much you eat.

sorry my mistake, beds training uses old moldal system
updated again

[htc16]

Bro, none of the buttons for offline training in bed works (I did check them all), it is impossible to train in bed at current state.

[baerlix]

https://www.youtube.com/watch?v=2w4J9xobqnA

soul seals is working on soul pit?

[ivansho92]

NPC'S aren't selling the bounty talisman to do bounty task.