Skip to content

AIP-9061 lowercase cli params #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/aip
Choose a base branch
from
Open

AIP-9061 lowercase cli params #316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
819f467
AIP-9061 lowercase cli params
talebzeghmi Jan 11, 2025
da4b565
AIP-9061 code comment
talebzeghmi Jan 11, 2025
ee5a3e1
comment update
talebzeghmi Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions metaflow/plugins/aip/aip_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,14 +414,15 @@ def run(


def _get_flow_parameters(kwargs, obj) -> Dict[str, Any]:
# AIP-9061(talebz): Black lowercases kwargs parameter names, so we call lower()
def _convert_value(param: parameters.Parameter):
v = kwargs.get(param.name)
v = kwargs.get(param.name.lower())
return json.dumps(v) if param.kwargs.get("type") == JSONType else v

flow_parameters = {
param.name: _convert_value(param)
for _, param in obj.flow._get_parameters()
if kwargs.get(param.name) is not None
if kwargs.get(param.name.lower()) is not None
}
return flow_parameters

Expand Down
Loading