-
Notifications
You must be signed in to change notification settings - Fork 575
Feat: enable encryption support for SMB #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The smb library refuses to connect to shared that have enforced encryption unless the client allows encryption in the options
|
Looking at the various performance issues on the lib, you probably want to add the encryption toggle over my bare bones one 😉 |
|
Yes, I believe this will need a toggle, so this will be more like a feature request. Despite that I'm grateful the author created and open sourced SMBJ, I also really hope we can have a better SMB library which simply does the encryption negotiation (and has less bugs - I often see crash reports due to this library). |
|
Hi, any ETA in sight for this feature? This would probably be useful for a lot of people, as you seemingly would have the only FOSS android files app that supports encrypted SMB shares. |
|
I'm sorry I coded this from knowledge and the snipit provided by the person
asking for help
Nick Rodriguez
…On Sat, Oct 5, 2024, 2:19 PM Hai Zhang ***@***.***> wrote:
Yes, I believe this will need a toggle. Despite that I'm grateful the
author created and open sourced SMBJ, I also really hope we can have a
better SMB library which simply does the encryption negotiation (and has
less bugs - I often see crash reports due to this library).
—
Reply to this email directly, view it on GitHub
<#1271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIYNKVBLLSCGDPLJI6KGJDTZ2AUR3AVCNFSM6AAAAABKTS2SNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGEZTSNZZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
This feature is quite important. https://www.chiphell.com/forum.php?mod=viewthread&tid=2465332&extra=page%3D1&page=3 |
(Before we go on, yes I've read your PR template, yes I'm aware that you don't accept contributions 1:1. The PR is trivial however, consider this to be in the public domain.
Mostly just want to get the ball rolling into the right direction)
I have a few shares on the same samba host (linux box) that has for some of those shares enforced encryption
The smb library you are using by default doesn't negotiate encryption support, if you connect to the host, leading to EPERM when the home share gets accessed as an example, while the media share is still accessible.
In order that the encryption support is actually enabled by the lib, you need to do so with the config builder.
Not sure if you want to unconditionally do so or if this needs to be some sort of frontend setting, but as you anyway want to do the coding on your own I didn't bother trying to do so.