fix(e2e-nightly): add signet to BTC client resolveParams#4561
fix(e2e-nightly): add signet to BTC client resolveParams#4561ws4charlie merged 2 commits intomainfrom
Conversation
PR #4539 added signet support to the e2e config layer but missed the resolveParams function in the zetaclient BTC client, causing "unknown chain params signet" errors in e2e tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request adds SigNet chain parameter support to the Bitcoin client by introducing a new case in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.16.4)zetaclient/chains/bitcoin/client/client.go┌──────────────┐ �[32m✔�[39m �[1mOpengrep OSS�[0m �[1m Loading rules from local config...�[0m Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
signetcase toresolveParamsinzetaclient/chains/bitcoin/client/client.goContext
PR #4539 added signet support to the e2e config layer (
e2e/config/config.go,cmd/zetae2e/config/clients.go) but missed theresolveParamsfunction in the zetaclient BTC client. This causes"unknown chain params "signet""errors when running BTC e2e tests on testnet (signet).zetae2e bitcoin-addressfails withunknown chain params "signet"resolveParams("signet")returnschains.SigNetParamscorrectlyThis PR is a companion to e2e#142 which switches
btc_network_namefromtestnet3tosignet.Test plan
zetae2e bitcoin-addressworks with signet config🤖 Generated with Claude Code
Note
Low Risk
Low risk: a small, isolated change that only extends
resolveParamsto recognizesignetand map it tochains.SigNetParams.Overview
Fixes BTC client initialization for Signet configs by teaching
resolveParamsinzetaclient/chains/bitcoin/client/client.goto acceptchains.SigNetParams.Nameand returnchains.SigNetParamsinstead of erroring with "unknown chain params".Written by Cursor Bugbot for commit ead2f49. Configure here.
Summary by CodeRabbit