Skip to content

fix(e2e-nightly): add signet to BTC client resolveParams#4561

Merged
ws4charlie merged 2 commits intomainfrom
fix/btc-signet-resolve-params
Mar 16, 2026
Merged

fix(e2e-nightly): add signet to BTC client resolveParams#4561
ws4charlie merged 2 commits intomainfrom
fix/btc-signet-resolve-params

Conversation

@ws4charlie
Copy link
Contributor

@ws4charlie ws4charlie commented Mar 16, 2026

Summary

  • Add signet case to resolveParams in zetaclient/chains/bitcoin/client/client.go

Context

PR #4539 added signet support to the e2e config layer (e2e/config/config.go, cmd/zetae2e/config/clients.go) but missed the resolveParams function in the zetaclient BTC client. This causes "unknown chain params "signet"" errors when running BTC e2e tests on testnet (signet).

Before After
zetae2e bitcoin-address fails with unknown chain params "signet" resolveParams("signet") returns chains.SigNetParams correctly

This PR is a companion to e2e#142 which switches btc_network_name from testnet3 to signet.

Test plan

  • Verify zetae2e bitcoin-address works with signet config
  • Run BTC e2e tests on testnet with signet network name

🤖 Generated with Claude Code


Note

Low Risk
Low risk: a small, isolated change that only extends resolveParams to recognize signet and map it to chains.SigNetParams.

Overview
Fixes BTC client initialization for Signet configs by teaching resolveParams in zetaclient/chains/bitcoin/client/client.go to accept chains.SigNetParams.Name and return chains.SigNetParams instead of erroring with "unknown chain params".

Written by Cursor Bugbot for commit ead2f49. Configure here.

Summary by CodeRabbit

  • New Features
    • Added SigNet support to Bitcoin chain parameter resolution.

PR #4539 added signet support to the e2e config layer but missed
the resolveParams function in the zetaclient BTC client, causing
"unknown chain params signet" errors in e2e tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01738739-40ac-4ae7-b1a1-0e2e8ae1850f

📥 Commits

Reviewing files that changed from the base of the PR and between 4342585 and 64c2c2f.

📒 Files selected for processing (2)
  • changelog.md
  • zetaclient/chains/bitcoin/client/client.go

📝 Walkthrough

Walkthrough

This pull request adds SigNet chain parameter support to the Bitcoin client by introducing a new case in the resolveParams function to handle chains.SigNetParams. The change includes corresponding documentation in the changelog.

Changes

Cohort / File(s) Summary
SigNet Parameter Resolution
zetaclient/chains/bitcoin/client/client.go
Adds a new case statement in resolveParams to recognize and resolve chains.SigNetParams.Name, returning the appropriate SigNet parameters alongside existing MainNet, TestNet3, RegressionNet, and SimNet support.
Changelog Entry
changelog.md
Documents the addition of SigNet support to the Bitcoin client parameter resolution as a fix for the e2e "unknown chain params" error.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • kingpinXD
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding signet support to the BTC client's resolveParams function to fix e2e test failures.
Description check ✅ Passed The description provides context, motivation, and concrete test cases, though the testing checklist items are not marked as completed rather than omitted.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/btc-signet-resolve-params
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.16.4)
zetaclient/chains/bitcoin/client/client.go

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ws4charlie ws4charlie changed the title fix: add signet to BTC client resolveParams fix(e2e-nightly): add signet to BTC client resolveParams Mar 16, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ws4charlie ws4charlie requested a review from skosito March 16, 2026 18:17
@ws4charlie ws4charlie added E2E E2E tests related test Tests related labels Mar 16, 2026
@ws4charlie ws4charlie marked this pull request as ready for review March 16, 2026 18:26
@ws4charlie ws4charlie requested a review from a team as a code owner March 16, 2026 18:26
@ws4charlie ws4charlie enabled auto-merge March 16, 2026 18:27
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/client/client.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ws4charlie ws4charlie added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit c5e366f Mar 16, 2026
58 of 62 checks passed
@ws4charlie ws4charlie deleted the fix/btc-signet-resolve-params branch March 16, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E2E E2E tests related test Tests related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants