This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Added support for ThrowablePotionItems, Crossbows#204
Draft
JerryWester wants to merge 3 commits intozeroeightysix:fabricfrom
JerryWester:fabric-1.16
Draft
Added support for ThrowablePotionItems, Crossbows#204JerryWester wants to merge 3 commits intozeroeightysix:fabricfrom JerryWester:fabric-1.16
JerryWester wants to merge 3 commits intozeroeightysix:fabricfrom
JerryWester:fabric-1.16
Conversation
5HT2
approved these changes
Aug 10, 2020
Contributor
5HT2
left a comment
5HT2
left a comment
There was a problem hiding this comment.
potions lgtm, seems to work fine from my testing
zeroeightysix
changed the title
Owner
|
I couldn't reproduce crossbow arrows going further than the line says. Aside from fireworks supposedly having gravity, this looks fine. We can't shift the line to the middle anyways, as you wouldn't be able to see its trajectory that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crossbows need more work currently. Their power values are incorrect, and the line starts from the right side of the screen when the crossbow is in the center.