Skip to content

UMI mux test#278

Merged
aolofsson merged 2 commits into
mainfrom
rice/umi_mux_test
Apr 10, 2026
Merged

UMI mux test#278
aolofsson merged 2 commits into
mainfrom
rice/umi_mux_test

Conversation

@RiceShelley

Copy link
Copy Markdown
Contributor

Description

Simplified umi_mux ready logic, and added test for umi_mux.

Screenshot of constrained random test

image

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies umi_mux input-ready propagation logic and adds a new cocotb-based constrained-random testbench to validate mux behavior across arbitration modes and backpressure patterns.

Changes:

  • Refactor umi_mux umi_in_ready generation.
  • Add a new cocotb test (test_umi_mux.py) that drives multiple SUMI inputs and checks output transaction integrity.
  • Add an 8-to-1 wrapper RTL module for simulation (umi_mux_8_to_1.v).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
umi/sumi/umi_mux/rtl/umi_mux.v Updates ready-generation logic for mux inputs based on grants/out-ready.
tests/sumi/umi_mux/test_umi_mux.py Adds constrained-random cocotb test for mux arbitration/backpressure behavior.
tests/sumi/umi_mux/rtl/umi_mux_8_to_1.v Provides a concrete 8-input top-level wrapper to drive the parameterized mux in simulation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread umi/sumi/umi_mux/rtl/umi_mux.v

@aolofsson aolofsson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename it tb_umi_mux.v and place it next to test_umi_mux.py, it's not really rtl in this context. This would be a decent pattern to follow going forward.

@RiceShelley

Copy link
Copy Markdown
Contributor Author

I would rename it tb_umi_mux.v and place it next to test_umi_mux.py, it's not really rtl in this context. This would be a decent pattern to follow going forward.

Changed name

@RiceShelley RiceShelley requested a review from aolofsson April 10, 2026 14:28

@aolofsson aolofsson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aolofsson aolofsson merged commit 0c5cef4 into main Apr 10, 2026
3 of 4 checks passed
@aolofsson aolofsson deleted the rice/umi_mux_test branch April 10, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants