net: l2: ieee802154: add support for IEEE802154_CFI_DATA_REQUEST #99699
+55
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiriou
force-pushed
the
ieee802154_cfi_data_request
branch
from
cde2d88 to
11dfd54
Compare
jukkar
reviewed
Nov 20, 2025
| net_pkt_unref(pkt); | ||
| pkt = ieee802154_create_mac_cmd_frame( | ||
| iface, IEEE802154_CFI_DATA_REQUEST, ¶ms); | ||
| if (!pkt) { |
Member
There was a problem hiding this comment.
Please change this to if (pkt == NULL) { as dictated by MISRA so that we do not introduce new code that is using boolean checks for non boolean variables.
spiriou
force-pushed
the
ieee802154_cfi_data_request
branch
from
11dfd54 to
8f7ffb6
Compare
rlubos
reviewed
Nov 20, 2025
802.15.4 specifies that a device may send a DATA_REQUEST command to the coordinator after waiting for "macResponseWaitTime", starting after the acknowledgment to the association request command. This change adds support to generate DATA_REQUEST frames and sends one for the association usecase only. The two other usecases, for MLME-POLL or for beacon-enabled PAN, are not yet supported. Signed-off-by: Simon Piriou <[email protected]>
spiriou
force-pushed
the
ieee802154_cfi_data_request
branch
from
8f7ffb6 to
21a8603
Compare
|
rlubos
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
802.15.4 specifies that a device may send a DATA_REQUEST command to the coordinator after waiting for "macResponseWaitTime", starting after the acknowledgment to the association request command.
This change adds support to generate DATA_REQUEST frames and sends one for the association usecase only. The two other usecases, for MLME-POLL or for beacon-enabled PAN, are not yet supported.