Skip to content

net/l2/ieee802154: logging improvement for utils and nrf5 driver #99697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

net/l2/ieee802154: logging improvement for utils and nrf5 driver #99697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a742b
net: l2: ieee802154: skip filter removal for unassociated values
spiriou Nov 19, 2025
764febe
drivers: ieee802154: nrf5: improve debug logs
spiriou Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions drivers/ieee802154/ieee802154_nrf5.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ static int nrf5_set_pan_id(const struct device *dev, uint16_t pan_id)
sys_put_le16(pan_id, pan_id_le);
nrf_802154_pan_id_set(pan_id_le);

LOG_DBG("0x%x", pan_id);
LOG_DBG("pan_id 0x%x", pan_id);

return 0;
}
Expand All @@ -358,7 +358,7 @@ static int nrf5_set_short_addr(const struct device *dev, uint16_t short_addr)
sys_put_le16(short_addr, short_addr_le);
nrf_802154_short_address_set(short_addr_le);

LOG_DBG("0x%x", short_addr);
LOG_DBG("short_addr 0x%x", short_addr);

return 0;
}
Expand All @@ -381,7 +381,7 @@ static int nrf5_filter(const struct device *dev, bool set,
enum ieee802154_filter_type type,
const struct ieee802154_filter *filter)
{
LOG_DBG("Applying filter %u", type);
LOG_DBG("Applying filter %u set=%d", type, set);

if (!set) {
return -ENOTSUP;
Expand Down
6 changes: 4 additions & 2 deletions subsys/net/l2/ieee802154/ieee802154_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,8 @@ static inline void ieee802154_radio_remove_src_short_addr(struct net_if *iface,
const struct ieee802154_radio_api *radio =
net_if_get_device(iface)->api;

if (radio && (radio->get_capabilities(net_if_get_device(iface)) &
if (radio && (short_addr != IEEE802154_SHORT_ADDRESS_NOT_ASSOCIATED) &&
(radio->get_capabilities(net_if_get_device(iface)) &
IEEE802154_HW_FILTER)) {
struct ieee802154_filter filter;

Expand All @@ -264,7 +265,8 @@ static inline void ieee802154_radio_remove_pan_id(struct net_if *iface, uint16_t
const struct ieee802154_radio_api *radio =
net_if_get_device(iface)->api;

if (radio && (radio->get_capabilities(net_if_get_device(iface)) &
if (radio && (pan_id != IEEE802154_PAN_ID_NOT_ASSOCIATED) &&
(radio->get_capabilities(net_if_get_device(iface)) &
IEEE802154_HW_FILTER)) {
struct ieee802154_filter filter;

Expand Down