Skip to content

drivers: i3c: fix nibi builds #99693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −1
Open

drivers: i3c: fix nibi builds #99693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c646cbb
drivers: i3c: fix unused function warning
XenuIsWatching Nov 19, 2025
c893c98
drivers: i3c: cdns: fix warning when building without i3c_use_ibi
XenuIsWatching Nov 20, 2025
4eacfef
tests: drivers: build_all: i3c: add build for no ibis
XenuIsWatching Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drivers/i3c/i3c_cdns.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2774,7 +2774,9 @@ static void cdns_i3c_target_sdr_tx_thr_int_handler(const struct device *dev,
static void cdns_i3c_irq_handler(const struct device *dev)
{
const struct cdns_i3c_config *config = dev->config;
#if defined(CONFIG_I3C_CONTROLLER) && defined(CONFIG_I3C_USE_IBI) || defined(CONFIG_I3C_TARGET)
struct cdns_i3c_data *data = dev->data;
#endif
#ifdef CONFIG_I3C_CONTROLLER
uint32_t int_st = sys_read32(config->base + MST_ISR);

Expand Down
3 changes: 2 additions & 1 deletion drivers/i3c/i3c_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ int i3c_sec_i2c_attach(const struct device *dev, uint8_t static_addr, uint8_t lv
return ret;
}

#ifdef CONFIG_I3C_USE_IBI
static void i3c_sec_bus_reset(const struct device *dev)
{
struct i3c_device_desc *i3c_desc;
Expand All @@ -483,7 +484,7 @@ static void i3c_sec_bus_reset(const struct device *dev)
i3c_detach_i2c_device(i3c_i2c_desc);
}
}
#ifdef CONFIG_I3C_USE_IBI

/* call this from a workq after the interrupt from a controller */
void i3c_sec_handoffed(struct k_work *work)
{
Expand Down
15 changes: 15 additions & 0 deletions tests/drivers/build_all/i3c/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,18 @@ tests:
platform_allow: qemu_cortex_m3
tags: i3c_cdns i3c_dw
extra_args: "CONFIG_I3C_TARGET_ROLE_ONLY=y"
drivers.i3c.build.dual_role_nibi:
# will cover drivers without in-tree boards
platform_allow: qemu_cortex_m3
tags: i3c_cdns i3c_dw
extra_args: "CONFIG_I3C_DUAL_ROLE=y CONFIG_I3C_RTIO=y CONFIG_I3C_USE_IBI=n"
drivers.i3c.build.controller_role_only_nibi:
# will cover drivers without in-tree boards
platform_allow: qemu_cortex_m3
tags: i3c_cdns i3c_dw
extra_args: "CONFIG_I3C_CONTROLLER_ROLE_ONLY=y CONFIG_I3C_RTIO=y CONFIG_I3C_USE_IBI=n"
drivers.i3c.build.target_role_only_nibi:
# will cover drivers without in-tree boards
platform_allow: qemu_cortex_m3
tags: i3c_cdns i3c_dw
extra_args: "CONFIG_I3C_TARGET_ROLE_ONLY=y CONFIG_I3C_USE_IBI=n"