cfb: Skip non-existent font glyphs #99688
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change ensures that returned glyph exists in the current font. Signed-off-by: Maksim Salau <[email protected]>
zephyrbot
requested review from
JarmouniA,
VynDragon,
danieldegrasse and
jfischer-no
|
Contributor
Author
|
The #85434 PR has this fix too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change ensures that returned glyph exists in the current font.
This change fixes cases when neither a proper glyph nor space are present in a font.
The issue can be reproduced by changing the cfb_custom_font sample to print any symbol except for digits
1to6(e.g.A).