-
Notifications
You must be signed in to change notification settings - Fork 187
Add documentation for code conventions/style. Closes one task of #201 Documentation work item #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add documentation for code conventions/style. Closes one task of #201 Documentation work item #440
Conversation
|
@BrunoHenriqueCh is attempting to deploy a commit to the Shakeel's projects Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideIntroduces a comprehensive Markdown guide for the project’s ESLint-based code style rules to make conventions human-readable and accessible to contributors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a table of contents at the top of code-style.md so readers can quickly navigate to specific rules in this long document.
- It might help to include a direct link or reference to the .eslintrc.json in the repo and note how to regenerate or sync this doc when ESLint rules change to prevent drift.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a table of contents at the top of code-style.md so readers can quickly navigate to specific rules in this long document.
- It might help to include a direct link or reference to the .eslintrc.json in the repo and note how to regenerate or sync this doc when ESLint rules change to prevent drift.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Hi @BrunoHenriqueCh, thanks for the PR! Is there a better way to automate building this file? If ESLint conventions change, how do we keep this file updated? |
Good point |
|
@BrunoHenriqueCh Hi, yes please let’s find a way to automate this file. What do other projects do to document their code conventions? |
…s #201
Description
Adds a human-readable version of the project’s code style rules in doc/code-style.md, translating the existing .eslintrc.json configuration. This makes it easier for contributors to follow consistent coding conventions.
Related Issues
Issue 201 Documentation Work Items/ Code Style
#201
Checklist
Summary by Sourcery
Documentation: