V2 attributes #28
Open
V2 attributes #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanrz
approved these changes
Oct 27, 2025
| import java.util.Map; | ||
| import java.util.function.Function; | ||
|
|
||
| public class Attributes extends HashMap<String, Object> { |
There was a problem hiding this comment.
What were your inspirations for API design?
There was a problem hiding this comment.
I wanted:
- typed getters like
getInt,getList, andgetAttributesto avoid unsafe casting in user code - an Attributes builder with add (or set) and delete.
Maybe Attributes.of or Attributes.builder().add(...) would be more idiomatic for Java.
Do you have suggestions or preferences on how the API could be improved?
There was a problem hiding this comment.
I think it might be useful to consider how user-libraries, such as an OME-Zarr library, would want to access the attributes. Maybe they just want to take the ome (0.5) or multiscales (0.4) objects and parse for themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array.resize