This repository was archived by the owner on Jan 17, 2020. It is now read-only.
Add mouse wheel event#132
Open
Raveline wants to merge 3 commits into
Open
Conversation
Wheel scroll is supported only from 2.2.0
Author
|
About this embarrassing failing build: bumping the SDL2 bindings mean bumping the SDL2-lib as well. You build against trusty, which stays on 2.0.2. This PR needs 2.0.4, which is available by default on xenial, but not trusty. Which would mean either bumping to xenial rather than trusty for the CI, or doing some custom work to get the proper version on trusty. Both are beyond the scope of this PR. @z0w0, this is most likely more your call than mine ! Ping me if I can do anything to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to track and subscribe to mouse wheel events. It will provide the network with the vector of the mouse direction (it seems to be always 0 1 or 0 -1 depending on the wheel move, but I have a limited amount of devices to test this).
It means we need to bump the version of SDL2. I cannot guarantee, despite testing as much as I could, that this has no side-effect - but, once again, if there are, I couldn't find them.
The implementation follows the suggestions from SDL documentation : if SDL flagged the wheel as "flipped", we reverse the generated vector.
The rest should be rather straightforward.