Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Convert settings using product types to use product base types.
Additional info
There are 3 places that do use product types in settings now. First is product name profiles and
product_types_smart_selectfor create tool and loader tool. Product name template settings are meant to stay. Smart selection filters will stay for now as we have to modify tools for them which might be more complicated than I expected and less needed than time allows.Affected settings
ayon+settings://core/tools/publish/custom_staging_dir_profilesayon+settings://core/tools/publish/template_name_profilesayon+settings://core/tools/publish/hero_template_name_profilesayon+settings://core/version_start_category/profilesayon+settings://core/publish/CollectUSDLayerContributions/profilesayon+settings://core/publish/ExtractThumbnail/profilesayon+settings://core/publish/ExtractOIIOTranscode/profilesayon+settings://core/publish/ExtractOIIOPostProcess/profilesayon+settings://core/publish/ExtractReview/profilesayon+settings://core/publish/ExtractBurnin/profilesayon+settings://core/publish/IntegrateProductGroup/product_grouping_profilesayon+settings://core/publish/PreIntegrateThumbnails/integrate_profilesayon+settings://core/publish/CollectExplicitResolution/product_base_typesTesting notes: