Skip to content

Publish report viewer: Handle case if report is None#1664

Open
iLLiCiTiT wants to merge 3 commits intodevelopfrom
bugfix/publisher-empty-report-handling
Open

Publish report viewer: Handle case if report is None#1664
iLLiCiTiT wants to merge 3 commits intodevelopfrom
bugfix/publisher-empty-report-handling

Conversation

@iLLiCiTiT
Copy link
Member

Changelog Description

Handle report being None when cheching for blocking crashed paths.

Traceback

Traceback (most recent call last):
  File "C:\Users\user\Desktop\Prace\ayon\ayon-core\client\ayon_core\tools\publisher\publish_report_viewer\window.py", line 642, in _on_report_change
    self.set_report(report)
  File "C:\Users\user\Desktop\Prace\ayon\ayon-core\client\ayon_core\tools\publisher\publish_report_viewer\window.py", line 638, in set_report
    self._main_widget.set_report(report_data)
  File "C:\Users\user\Desktop\Prace\ayon\ayon-core\client\ayon_core\tools\publisher\publish_report_viewer\widgets.py", line 891, in set_report
    if report.blocking_crashed_paths:
AttributeError: 'NoneType' object has no attribute 'blocking_crashed_paths'

Testing notes:

  1. Publish report viewer does not crash on refresh.

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jan 27, 2026
@ynbot ynbot added the size/XS label Jan 27, 2026
@iLLiCiTiT iLLiCiTiT self-assigned this Jan 27, 2026
@iLLiCiTiT iLLiCiTiT requested review from BigRoy and antirotor January 27, 2026 13:27
@iLLiCiTiT iLLiCiTiT changed the title handle case if report is None Publish report viewer: Handle case if report is None Jan 28, 2026
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 29, 2026

Publish report viewer does not crash on refresh.

How do you force a refresh? :D Or what refresh do we mean?

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jan 29, 2026

How do you force a refresh? :D Or what refresh do we mean?

I don't know, I saw the error and find out: Hey, it can be None, I didn't know... I guess it happens either when window is opened first time, or on refresh which fails for some reason...

@ynbot ynbot moved this to Review In Progress in PR reviewing Jan 29, 2026
@BigRoy BigRoy requested a review from m-u-r-p-h-y January 29, 2026 12:58
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 30, 2026

I'll let @m-u-r-p-h-y review since he reported it and seemed he was able to produce the error previously.

Bonus points @m-u-r-p-h-y for explaining here when exactly it occurred ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: bug Something isn't working

Projects

Status: Review In Progress

Development

Successfully merging this pull request may close these issues.

4 participants